From: Sven Luther <sven.luther@wanadoo.fr>
To: Paul Mackerras <paulus@samba.org>
Cc: akpm@osdl.org, linuxppc-dev@ozlabs.org, luther@debian.org,
linuxppc64-dev@ozlabs.org
Subject: Re: [patch 38/43] Various powerpc 32bit ppc64 build fixes
Date: Sat, 29 Oct 2005 08:27:24 +0200 [thread overview]
Message-ID: <20051029062724.GA1893@localhost.localdomain> (raw)
In-Reply-To: <17251.2983.358202.164993@cargo.ozlabs.ibm.com>
On Sat, Oct 29, 2005 at 03:41:59PM +1000, Paul Mackerras wrote:
> Sven Luther writes:
>
> > +ifeq ($(CONFIG_6xx),y)
> > obj-$(CONFIG_PPC_PMAC) += pmac_pic.o pmac_setup.o pmac_time.o \
> > pmac_feature.o pmac_pci.o pmac_sleep.o \
> > pmac_low_i2c.o pmac_cache.o
> > +else
> > +obj-$(CONFIG_PPC_PMAC) += pmac_pic.o pmac_setup.o pmac_time.o \
> > + pmac_feature.o pmac_pci.o pmac_sleep.o \
> > + pmac_low_i2c.o
> > +endif
>
> This is a bit gross. How about:
Well, i sent to linuxppc-dev for comments too :)
> pmac-$(CONFIG_6xx) := pmac_cache.o
> obj-$(CONFIG_PPC_PMAC) += pmac_pic.o pmac_setup.o pmac_time.o \
> pmac_feature.o pmac_pci.o pmac_sleep.o \
> pmac_low_i2c.o $(pmac-y)
>
> Care to send a revised patch?
Sure, i will do so early next week.
Friendly,
Sven Luther
prev parent reply other threads:[~2005-10-29 6:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-29 0:46 [patch 38/43] Various powerpc 32bit ppc64 build fixes akpm
2005-10-29 5:41 ` Paul Mackerras
2005-10-29 6:27 ` Sven Luther [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051029062724.GA1893@localhost.localdomain \
--to=sven.luther@wanadoo.fr \
--cc=akpm@osdl.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=luther@debian.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).