use of phy_connect() in drivers/net/gianfar.c ?

use of phy_connect() in drivers/net/gianfar.c ?

[Wolfgang Denk]

Hello,

this commit in the 2.6.14 tree is breaking drivers/net/gianfar.c  for
me:

	Commit: bb40dcbb0fcebe1df08ba261483fcc38b307d063
	Author: Andy Fleming <afleming@freescale.com>  2005-09-24 04:54:21
	Committer: Jeff Garzik <jgarzik@pobox.com>  2005-09-24 04:54:21
	Parent: acc4b985a6f8f22a0e826692894a4af234764001 ([PATCH] orinoco: Bump version to 0.15rc3.)
	Child:  8cee0cd5bec53b78dd3c43a73b27821a688133e6 ([netdrvr] delete CONFIG_PHYCONTROL)

	    [netdrvr gianfar] use new phy layer
	        
	    Signed-off-by: Andy Fleming <afleming@freescale.com>
	    Signed-off-by: Jeff Garzik <jgarzik@pobox.com>

I get:

drivers/net/gianfar.c: In function `init_phy':
drivers/net/gianfar.c:410: error: structure has no member named `bus_id'


Am I missing something?

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
In C we had to code our own bugs, in C++ we can inherit them.

Re: use of phy_connect() in drivers/net/gianfar.c ?

[Matthew McClintock]

Hello Wolfgang,

As far as I understand there are patches in the -mm tree with contain
the updates for the Gianfar driver. The issue is due to a
synchronization issue with the new PHY abstraction layer that was added.
I know Andy will not be back at his computer until Monday, you can wait
until then or look for the patch in the -mm tree.

Regards,
Matthew

On Sat, 2005-10-29 at 13:40 -0700, Wolfgang Denk wrote:
> Hello,
> 
> this commit in the 2.6.14 tree is breaking drivers/net/gianfar.c  for 
> me:
> 
>         Commit: bb40dcbb0fcebe1df08ba261483fcc38b307d063 
>         Author: Andy Fleming <afleming@freescale.com>  2005-09-24
> 04:54:21 
>         Committer: Jeff Garzik <jgarzik@pobox.com>  2005-09-24
> 04:54:21 
>         Parent: acc4b985a6f8f22a0e826692894a4af234764001 ([PATCH]
> orinoco: Bump version to 0.15rc3.) 
>         Child:  8cee0cd5bec53b78dd3c43a73b27821a688133e6 ([netdrvr]
> delete CONFIG_PHYCONTROL)
> 
>             [netdrvr gianfar] use new phy layer 
>                  
>             Signed-off-by: Andy Fleming <afleming@freescale.com> 
>             Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
> 
> I get:
> 
> drivers/net/gianfar.c: In function `init_phy': 
> drivers/net/gianfar.c:410: error: structure has no member named
> `bus_id'
> 
> 
> Am I missing something?
> 
> Best regards,
> 
> Wolfgang Denk
> 
> --  
> Software Engineering:  Embedded and Realtime Systems,  Embedded Linux 
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de 
> In C we had to code our own bugs, in C++ we can inherit them. 
> _______________________________________________ 
> Linuxppc-dev mailing list 
> Linuxppc-dev@ozlabs.org 
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
> 

Re: use of phy_connect() in drivers/net/gianfar.c ?

[Wolfgang Denk]

Dear Matthew,

in message <1130632707.7470.16.camel@localhost.localdomain> you wrote:
> 
> As far as I understand there are patches in the -mm tree with contain
> the updates for the Gianfar driver. The issue is due to a

Do you happen to know of a specific (set of) patch(es)? URL?

> synchronization issue with the new PHY abstraction layer that was added.

Yes, obviously. But I am still so naïve to expect that  such  changes
would not make it untested (the code is not even compile clean) to an
official kernel release like 2.6.14 ?

> I know Andy will not be back at his computer until Monday, you can wait
> until then or look for the patch in the -mm tree.

Is there a git repository somewhere for the mm tree?

Best regards,

Wolfgang Denk

-- 
Software Engineering:  Embedded and Realtime Systems,  Embedded Linux
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
(null cookie; hope that's ok)

Re: use of phy_connect() in drivers/net/gianfar.c ?

[Matthew McClintock]

On Sun, 2005-10-30 at 08:18 -0700, Wolfgang Denk wrote:

> > As far as I understand there are patches in the -mm tree with
> contain=20
> > the updates for the Gianfar driver. The issue is due to a
>=20
> Do you happen to know of a specific (set of) patch(es)? URL?

I believe this is the patch, however Andy can let you know  for sure on
Monday if I am wrong.

http://ozlabs.org/pipermail/linuxppc-dev/2005-October/020178.html

>=20
> > synchronization issue with the new PHY abstraction layer that was
> added.
>=20
> Yes, obviously. But I am still so na=C3=AFve to expect that  such  change=
s=20
> would not make it untested (the code is not even compile clean) to an=20
> official kernel release like 2.6.14 ?

I assure you we made our best effort to get it all in, but it did not
work out like we wanted.

-Matthew

Re: use of phy_connect() in drivers/net/gianfar.c ?

[Andy Fleming]

On Oct 30, 2005, at 09:18, Wolfgang Denk wrote:

> Dear Matthew,
>
> in message <1130632707.7470.16.camel@localhost.localdomain> you wrote:
> >
> > As far as I understand there are patches in the -mm tree with =20
> contain
> > the updates for the Gianfar driver. The issue is due to a
>
> Do you happen to know of a specific (set of) patch(es)? URL?
>
> > synchronization issue with the new PHY abstraction layer that was =20=

> added.
>
> Yes, obviously. But I am still so na=EFve to expect that  such  =
changes
> would not make it untested (the code is not even compile clean) to an
> official kernel release like 2.6.14 ?

Sorry about that.  The problem was that the offending changes needed =20
to be broken into two patches.  The PHY Layer (a separate patch) =20
required changes to the driver, which required concurrent changes in =20
the platform init code (the MDIO bus was set up as its own device).  =20
Unfortunately, the driver changes needed to be handled through =20
netdev, while the platform changes were through -mm.  We tried to =20
sync it up so that the changes got into Linus' tree at the same time, =20=

but that did not happen.  If you pull the tree today, you will find =20
that patch is now in the main tree.