linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Linus Torvalds <torvalds@osdl.org>,
	Michael Buesch <mbuesch@freenet.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [2.6 patch] PPC_PREP: remove unneeded exports
Date: Sun, 13 Nov 2005 02:26:09 +0100	[thread overview]
Message-ID: <20051113012608.GH21448@stusta.de> (raw)
In-Reply-To: <1131834667.7406.49.camel@gaston>

On Sun, Nov 13, 2005 at 09:31:06AM +1100, Benjamin Herrenschmidt wrote:
> 
> > ucSystemType is a variable that is EXPORT_SYMBOL'ed but never used in 
> > any way.
> > 
> > _prep_type is a variable that is needlessly EXPORT_SYMBOL'ed.
> 
> Therse are old PREP stuffs
>...

Is the patch below OK?

> Ben.

cu
Adrian


<--  snip  -->


This patch removes the EXPORT_SYMBOL'ed but completely unused variable 
ucSystemType and removes the unneeded EXPORT_SYMBOL(_prep_type).


Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 arch/powerpc/kernel/ppc_ksyms.c |    5 -----
 arch/ppc/kernel/ppc_ksyms.c     |    4 ----
 arch/ppc/platforms/prep_setup.c |    1 -
 include/asm-powerpc/processor.h |    1 -
 4 files changed, 11 deletions(-)

--- linux-2.6.15-rc1/include/asm-powerpc/processor.h.old	2005-11-13 01:44:12.000000000 +0100
+++ linux-2.6.15-rc1/include/asm-powerpc/processor.h	2005-11-13 01:44:25.000000000 +0100
@@ -68,7 +68,6 @@
  * vendor. Board revision is also made available. This will be moved
  * elsewhere soon
  */
-extern unsigned char ucSystemType;
 extern unsigned char ucBoardRev;
 extern unsigned char ucBoardRevMaj, ucBoardRevMin;
 
--- linux-2.6.15-rc1/arch/ppc/platforms/prep_setup.c.old	2005-11-13 01:44:36.000000000 +0100
+++ linux-2.6.15-rc1/arch/ppc/platforms/prep_setup.c	2005-11-13 01:44:40.000000000 +0100
@@ -72,7 +72,6 @@
 
 TODC_ALLOC();
 
-unsigned char ucSystemType;
 unsigned char ucBoardRev;
 unsigned char ucBoardRevMaj, ucBoardRevMin;
 
--- linux-2.6.15-rc1/arch/ppc/kernel/ppc_ksyms.c.old	2005-11-13 01:44:49.000000000 +0100
+++ linux-2.6.15-rc1/arch/ppc/kernel/ppc_ksyms.c	2005-11-13 01:44:54.000000000 +0100
@@ -82,10 +82,6 @@
 EXPORT_SYMBOL(ISA_DMA_THRESHOLD);
 EXPORT_SYMBOL(DMA_MODE_READ);
 EXPORT_SYMBOL(DMA_MODE_WRITE);
-#if defined(CONFIG_PPC_PREP)
-EXPORT_SYMBOL(_prep_type);
-EXPORT_SYMBOL(ucSystemType);
-#endif
 
 #if !defined(__INLINE_BITOPS)
 EXPORT_SYMBOL(set_bit);
--- linux-2.6.15-rc1/arch/powerpc/kernel/ppc_ksyms.c.old	2005-11-13 01:45:06.000000000 +0100
+++ linux-2.6.15-rc1/arch/powerpc/kernel/ppc_ksyms.c	2005-11-13 01:45:12.000000000 +0100
@@ -76,11 +76,6 @@
 EXPORT_SYMBOL(sys_sigreturn);
 #endif
 
-#if defined(CONFIG_PPC_PREP)
-EXPORT_SYMBOL(_prep_type);
-EXPORT_SYMBOL(ucSystemType);
-#endif
-
 EXPORT_SYMBOL(strcpy);
 EXPORT_SYMBOL(strncpy);
 EXPORT_SYMBOL(strcat);

  parent reply	other threads:[~2005-11-13  1:26 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.64.0511111753080.3263@g5.osdl.org>
2005-11-12 20:45 ` Linuv 2.6.15-rc1 Michael Buesch
2005-11-12 21:00   ` Linus Torvalds
2005-11-12 21:37     ` Michael Buesch
2005-11-12 21:53       ` Adrian Bunk
2005-11-12 21:57         ` Michael Buesch
2005-11-12 22:20           ` Adrian Bunk
2005-11-12 22:31             ` Benjamin Herrenschmidt
2005-11-12 23:51               ` Ulrich Teichert
2005-11-13  9:17                 ` Geert Uytterhoeven
2005-11-13 14:46                   ` Powerstack II (was: Re: Linuv 2.6.15-rc1) Ulrich Teichert
2005-11-13  1:26               ` Adrian Bunk [this message]
2005-11-13  3:23                 ` [2.6 patch] PPC_PREP: remove unneeded exports Benjamin Herrenschmidt
2005-11-14 19:56               ` Linuv 2.6.15-rc1 Tom Rini
2005-11-12 22:08       ` Olof Johansson
2005-11-12 22:25       ` Benjamin Herrenschmidt
2005-11-12 22:33         ` Michael Buesch
2005-11-13 16:37         ` Kumar Gala
2005-11-13 20:59           ` Benjamin Herrenschmidt
2005-11-15 18:53             ` Olaf Hering
2005-11-14  1:04       ` Jesper Juhl
2005-11-12 22:24     ` Benjamin Herrenschmidt
2005-11-12 23:13       ` asm/delay.h missing on powerpc (was: Re: Linuv 2.6.15-rc1) Michael Buesch
2005-11-13  0:33         ` Benjamin Herrenschmidt
2005-11-13  9:54           ` Michael Buesch
2005-11-12 21:28   ` PowerBook G4 boot failure " Alexey Dobriyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051113012608.GH21448@stusta.de \
    --to=bunk@stusta.de \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mbuesch@freenet.de \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).