From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fed1rmmtao03.cox.net (fed1rmmtao03.cox.net [68.230.241.36]) by ozlabs.org (Postfix) with ESMTP id A893B68713 for ; Tue, 15 Nov 2005 06:57:06 +1100 (EST) Date: Mon, 14 Nov 2005 12:56:39 -0700 From: Tom Rini To: Benjamin Herrenschmidt Message-ID: <20051114195639.GI3839@smtp.west.cox.net> References: <200511122237.17157.mbuesch@freenet.de> <20051112215304.GB21448@stusta.de> <200511122257.05552.mbuesch@freenet.de> <20051112222045.GC21448@stusta.de> <1131834667.7406.49.camel@gaston> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1131834667.7406.49.camel@gaston> Cc: Linux Kernel Mailing List , Adrian Bunk , linuxppc-dev@ozlabs.org, Linus Torvalds , Michael Buesch Subject: Re: Linuv 2.6.15-rc1 List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Sun, Nov 13, 2005 at 09:31:06AM +1100, Benjamin Herrenschmidt wrote: > > > ucSystemType is a variable that is EXPORT_SYMBOL'ed but never used in > > any way. > > > > _prep_type is a variable that is needlessly EXPORT_SYMBOL'ed. > > Therse are old PREP stuffs > > > But prep_init points to the real problem: > > > > CONFIG_PPC_PREP requires code from arch/ppc/platforms/, but this > > directory is never visited. > > > > What is the correct fix? > > Migrate the code from arch/ppc/platforms/ to arch/powerpc/platforms/ ? > > Yes, PREP need to be migrated, but that includes adding some minimum > device-tree support for it among others. And few people still have PREP > machines, I'm not even sure we have access to one here in ozlabs... I > think for 2.6.15, we'd better just disable it in .config for > ARCH=powerpc. I think we really should just drop _prep_type from being exported. the uc* stuff doesn't look to be used, but we can clean that up as its converted to arch/powerpc. But I don't think anything out of tree uses _prep_type (it's used at a very low level, it really couldn't be used at the modular level). As an occasional PReP monkey, Acked-by: Tom Rini -- Tom Rini http://gate.crashing.org/~trini/