* [PATCH] powerpc: put page page_to_virt for Book-e processors
@ 2005-11-14 23:21 Kumar Gala
2005-11-15 9:20 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Kumar Gala @ 2005-11-14 23:21 UTC (permalink / raw)
To: Paul Mackerras; +Cc: linuxppc-dev, linuxppc64-dev
Book-E processors use page_to_virt since we have to always translate.
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
commit 62ac3a10f41d7d300cf82846348f65eab0dbfd40
tree 039f1c393bd77fb8c6daf1c8ebd883c9a72be6e2
parent ed24c128ba54329d142c4d4c7c5e05cec6065b08
author Kumar Gala <galak@kernel.crashing.org> Mon, 14 Nov 2005 17:22:35 -0600
committer Kumar Gala <galak@kernel.crashing.org> Mon, 14 Nov 2005 17:22:35 -0600
include/asm-powerpc/page.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/asm-powerpc/page.h b/include/asm-powerpc/page.h
index 18c1e5e..e34a2ba 100644
--- a/include/asm-powerpc/page.h
+++ b/include/asm-powerpc/page.h
@@ -53,6 +53,7 @@
#endif
#define virt_to_page(kaddr) pfn_to_page(__pa(kaddr) >> PAGE_SHIFT)
+#define page_to_virt(page) __va(page_to_pfn(page) << PAGE_SHIFT)
#define pfn_to_kaddr(pfn) __va((pfn) << PAGE_SHIFT)
#define virt_addr_valid(kaddr) pfn_valid(__pa(kaddr) >> PAGE_SHIFT)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: put page page_to_virt for Book-e processors
2005-11-14 23:21 [PATCH] powerpc: put page page_to_virt for Book-e processors Kumar Gala
@ 2005-11-15 9:20 ` Christoph Hellwig
2005-11-15 16:45 ` Kumar Gala
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2005-11-15 9:20 UTC (permalink / raw)
To: Kumar Gala; +Cc: linuxppc-dev, linuxppc64-dev
On Mon, Nov 14, 2005 at 05:21:44PM -0600, Kumar Gala wrote:
> Book-E processors use page_to_virt since we have to always translate.
Why can't you use the proper page_address() macro?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] powerpc: put page page_to_virt for Book-e processors
2005-11-15 9:20 ` Christoph Hellwig
@ 2005-11-15 16:45 ` Kumar Gala
0 siblings, 0 replies; 3+ messages in thread
From: Kumar Gala @ 2005-11-15 16:45 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linuxppc-dev, linuxppc64-dev
On Tue, 15 Nov 2005, Christoph Hellwig wrote:
> On Mon, Nov 14, 2005 at 05:21:44PM -0600, Kumar Gala wrote:
> > Book-E processors use page_to_virt since we have to always translate.
>
> Why can't you use the proper page_address() macro?
I really want is lowmem_page_address() since the only current ppc user of
page_to_virt() in include/asm-ppc/pgalloc.h is pmd_populate() for book-e.
We have to have pages in lowmem.
- kumar
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-11-15 16:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-14 23:21 [PATCH] powerpc: put page page_to_virt for Book-e processors Kumar Gala
2005-11-15 9:20 ` Christoph Hellwig
2005-11-15 16:45 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).