linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1 kernel 2.6.15-rc1] Fix copy-paste bug after _Convert platform drivers to use_ (again)
@ 2005-11-15 18:53 Andrey Volkov
  0 siblings, 0 replies; 4+ messages in thread
From: Andrey Volkov @ 2005-11-15 18:53 UTC (permalink / raw)
  To: Russell King; +Cc: linux-kernel, ML linuxppc-embedded

Hello Russell,

I fear it is not a last patch of such kind :(.
Please recheck places where you are changed
pdev<->dev.

-- 
Regards
Andrey Volkov

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/1 kernel 2.6.15-rc1] Fix copy-paste bug after _Convert platform drivers to use_ (again)
@ 2005-11-15 18:54 Andrey Volkov
  2005-11-15 19:06 ` Russell King
  2005-11-17 16:10 ` Russell King
  0 siblings, 2 replies; 4+ messages in thread
From: Andrey Volkov @ 2005-11-15 18:54 UTC (permalink / raw)
  To: Russell King; +Cc: linux-kernel, ML linuxppc-embedded

[-- Attachment #1: Type: text/plain, Size: 147 bytes --]

Hello Russell,

I fear it is not a last patch of such kind :(.
Please recheck places where you are changed
pdev<->dev.

-- 
Regards
Andrey Volkov


[-- Attachment #2: ohci-ohci-ppc-soc.diff --]
[-- Type: text/plain, Size: 597 bytes --]

Fix copy-paste bug in ohci-ppc-soc.c(ohci_hcd_ppc_soc_drv_remove)

Sign-off-by: Andrey Volkov <avolkov@varma-el.com>
---

diff --git a/drivers/usb/host/ohci-ppc-soc.c b/drivers/usb/host/ohci-ppc-soc.c
index 1875576..2ec6a78 100644
--- a/drivers/usb/host/ohci-ppc-soc.c
+++ b/drivers/usb/host/ohci-ppc-soc.c
@@ -185,7 +185,7 @@ static int ohci_hcd_ppc_soc_drv_probe(st
 
 static int ohci_hcd_ppc_soc_drv_remove(struct platform_device *pdev)
 {
-	struct usb_hcd *hcd = platform_get_drvdata(dev);
+	struct usb_hcd *hcd = platform_get_drvdata(pdev);
 
 	usb_hcd_ppc_soc_remove(hcd, pdev);
 	return 0;

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1 kernel 2.6.15-rc1] Fix copy-paste bug after _Convert platform drivers to use_ (again)
  2005-11-15 18:54 [PATCH 1/1 kernel 2.6.15-rc1] Fix copy-paste bug after _Convert platform drivers to use_ (again) Andrey Volkov
@ 2005-11-15 19:06 ` Russell King
  2005-11-17 16:10 ` Russell King
  1 sibling, 0 replies; 4+ messages in thread
From: Russell King @ 2005-11-15 19:06 UTC (permalink / raw)
  To: Andrey Volkov; +Cc: linux-kernel, ML linuxppc-embedded

On Tue, Nov 15, 2005 at 09:54:32PM +0300, Andrey Volkov wrote:
> Hello Russell,
> 
> I fear it is not a last patch of such kind :(.
> Please recheck places where you are changed
> pdev<->dev.

Either that will have to wait a number of days or someone else will
have to do that.  I'm sorry but I'm rather unwell and in no fit state
to do anything major with kernels atm.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 1/1 kernel 2.6.15-rc1] Fix copy-paste bug after _Convert platform drivers to use_ (again)
  2005-11-15 18:54 [PATCH 1/1 kernel 2.6.15-rc1] Fix copy-paste bug after _Convert platform drivers to use_ (again) Andrey Volkov
  2005-11-15 19:06 ` Russell King
@ 2005-11-17 16:10 ` Russell King
  1 sibling, 0 replies; 4+ messages in thread
From: Russell King @ 2005-11-17 16:10 UTC (permalink / raw)
  To: Andrey Volkov; +Cc: linux-kernel, ML linuxppc-embedded

On Tue, Nov 15, 2005 at 09:54:32PM +0300, Andrey Volkov wrote:
> I fear it is not a last patch of such kind :(.
> Please recheck places where you are changed
> pdev<->dev.

Applied.  However, what you ask is to review the entire kernel looking
for a one-character error needle in a massive haystack.  That's a job
better suited to compilers than eyes.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2005-11-17 16:10 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-15 18:54 [PATCH 1/1 kernel 2.6.15-rc1] Fix copy-paste bug after _Convert platform drivers to use_ (again) Andrey Volkov
2005-11-15 19:06 ` Russell King
2005-11-17 16:10 ` Russell King
  -- strict thread matches above, loose matches on Subject: below --
2005-11-15 18:53 Andrey Volkov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).