From: Matt Porter <mporter@kernel.crashing.org>
To: David Updegraff <dave@cray.com>
Cc: linux-ppc-embedded <linuxppc-embedded@ozlabs.org>
Subject: Re: gianfar generic PHY assumptions.
Date: Thu, 17 Nov 2005 16:14:58 -0700 [thread overview]
Message-ID: <20051117161458.A8071@cox.net> (raw)
In-Reply-To: <437CFB43.4060400@cray.com>; from dave@cray.com on Thu, Nov 17, 2005 at 03:50:59PM -0600
On Thu, Nov 17, 2005 at 03:50:59PM -0600, David Updegraff wrote:
> Hi.
>
> This patch lets gianfar work on 83xx (or 85xx??) boards that have
> Generic PHYs on them that do _NOT_ happen to have an IRQ line wired to
> external_15. Surely reasonable that if we can't ID the PHY that its
> probably not irq-wired the Freescale-ADS "way"...
>
> It was critical for us; perhaps usefull for others.
Aside from the fact that the patch doesn't apply against the
current kernel due to the change of gianfar to use the phy
layer...why wouldn't you just set the board_flags field
appropriately in your board port? If you don't use a phy interrupt
then don't set the flag claiming that you do. stx_gp3.c doesn't
make use of the phy interrupt functionality, as an example.
I looked at an older kernel and I'm not sure where you see external
15 being used. It seems to be EXT5 on all the Fscale boards.
-Matt
prev parent reply other threads:[~2005-11-17 23:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-17 21:50 gianfar generic PHY assumptions David Updegraff
2005-11-17 23:07 ` Kumar Gala
2005-11-17 23:14 ` Matt Porter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051117161458.A8071@cox.net \
--to=mporter@kernel.crashing.org \
--cc=dave@cray.com \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).