From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Vitaly Bordug <vbordug@dev.rtsoft.ru>,
Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-embedded list <linuxppc-embedded@ozlabs.org>
Subject: Re: [PATCH] 8xx PCMCIA: support for MPC885ADS and MPC866ADS
Date: Wed, 23 Nov 2005 10:53:26 -0200 [thread overview]
Message-ID: <20051123125326.GB4526@logos.cnet> (raw)
In-Reply-To: <437E048B.2020605@dev.rtsoft.ru>
Hi Vitaly,
On Fri, Nov 18, 2005 at 07:42:51PM +0300, Vitaly Bordug wrote:
> This adds adds PCMCIA supported for both MPC885ADS and MPC866ADS.
>
> This is established not together with FADS, because 885 does not have
> io_block_mapping() for BCSR area.
> Also, some cleanups done both for 885ADS and MBX.
>
> Signed-off-by: Vitaly Bordug <vbordug@ru.mvista.com>
<snip>
> + bcsr_io = ioremap(BCSR1, sizeof(unsigned long));
Shouldnt you handle ioremap() failure? Most 85xx code written
by Kumar also does not.
next prev parent reply other threads:[~2005-11-23 18:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-18 16:42 [PATCH] 8xx PCMCIA: support for MPC885ADS and MPC866ADS Vitaly Bordug
2005-11-23 12:53 ` Marcelo Tosatti [this message]
2005-11-23 18:42 ` Kumar Gala
2005-11-23 20:22 ` Dan Malek
2005-11-23 15:13 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051123125326.GB4526@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=vbordug@dev.rtsoft.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).