From: Olaf Hering <olh@suse.de>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] generate COFF zImage in arch/powerpc/boot
Date: Wed, 23 Nov 2005 23:38:27 +0100 [thread overview]
Message-ID: <20051123223827.GA20793@suse.de> (raw)
In-Reply-To: <17284.61088.219693.162392@cargo.ozlabs.ibm.com>
On Thu, Nov 24, Paul Mackeras wrote:
> Olaf Hering writes:
>
> > It just died while uncompressing vmlinux. Some unaligned load.
> > So we either need a very simple byte by byte memcpy, or my version below.
>
> This should achieve the same effect and is quite a bit simpler. Your
> version looks a bit strange - it copies 1-3 bytes to align the source
> pointer, then copies 1-3 bytes to align the destination pointer, then
> if the source pointer isn't aligned it goes back and tries again... :)
Maybe I miss the point, but if the src is unaligned, and we align it,
dest will change as well and may be unaligned?
--
short story of a lazy sysadmin:
alias appserv=wotan
next prev parent reply other threads:[~2005-11-23 22:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-18 6:06 [PATCH] generate COFF zImage in arch/powerpc/boot Paul Mackerras
2005-11-18 7:51 ` Olaf Hering
2005-11-18 22:13 ` Olaf Hering
2005-11-18 23:16 ` Olaf Hering
2005-11-19 3:45 ` Paul Mackerras
2005-11-19 8:46 ` Olaf Hering
2005-11-19 9:12 ` Olaf Hering
2005-11-19 10:29 ` Olaf Hering
2005-11-19 17:29 ` Olaf Hering
2005-11-19 20:47 ` Olaf Hering
2005-11-23 20:21 ` Olaf Hering
2005-11-23 22:35 ` Paul Mackerras
2005-11-23 22:38 ` Olaf Hering [this message]
2005-11-23 22:58 ` Olaf Hering
2005-11-23 23:06 ` Paul Mackerras
2005-12-10 18:31 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051123223827.GA20793@suse.de \
--to=olh@suse.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).