* [PATCH] ppc32: fix treeboot image entrypoint
@ 2005-11-24 21:38 Eugene Surovegin
2005-11-28 22:34 ` Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Eugene Surovegin @ 2005-11-24 21:38 UTC (permalink / raw)
To: Andrew Morton; +Cc: Tom Rini, linuxppc-embedded
Correctly specify treeboot based image entrypoint. Currently makefile
uses $(ENTRYPOINT) which isn't defined anywhere. Each board port sets
entrypoint-$(CONFIG_BOARD_NAME) instead.
Without this patch I cannot boot Ocotea (PPC440GX eval board) anymore.
I was getting random "OS panic" errors from OpenBIOS for a while, but
with current kernel I get them all the time (probably because image
became bigger).
Signed-off-by: Eugene Surovegin <ebs@ebshome.net>
---
diff --git a/arch/ppc/boot/simple/Makefile b/arch/ppc/boot/simple/Makefile
index 82df88b..f3e9c53 100644
--- a/arch/ppc/boot/simple/Makefile
+++ b/arch/ppc/boot/simple/Makefile
@@ -262,11 +262,11 @@ $(images)/zImage.initrd-STRIPELF: $(obj)
skip=64 bs=1k
$(images)/zImage-TREE: $(obj)/zvmlinux $(MKTREE)
- $(MKTREE) $(obj)/zvmlinux $(images)/zImage.$(end-y) $(ENTRYPOINT)
+ $(MKTREE) $(obj)/zvmlinux $(images)/zImage.$(end-y) $(entrypoint-y)
$(images)/zImage.initrd-TREE: $(obj)/zvmlinux.initrd $(MKTREE)
$(MKTREE) $(obj)/zvmlinux.initrd $(images)/zImage.initrd.$(end-y) \
- $(ENTRYPOINT)
+ $(entrypoint-y)
$(images)/zImage-PPLUS: $(obj)/zvmlinux $(MKPREP) $(MKBUGBOOT)
$(MKPREP) -pbp $(obj)/zvmlinux $(images)/zImage.$(end-y)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ppc32: fix treeboot image entrypoint
2005-11-24 21:38 [PATCH] ppc32: fix treeboot image entrypoint Eugene Surovegin
@ 2005-11-28 22:34 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2005-11-28 22:34 UTC (permalink / raw)
To: Andrew Morton, Matt Porter, linuxppc-embedded
On Thu, Nov 24, 2005 at 01:38:21PM -0800, Eugene Surovegin wrote:
> Correctly specify treeboot based image entrypoint. Currently makefile
> uses $(ENTRYPOINT) which isn't defined anywhere. Each board port sets
> entrypoint-$(CONFIG_BOARD_NAME) instead.
>
> Without this patch I cannot boot Ocotea (PPC440GX eval board) anymore.
> I was getting random "OS panic" errors from OpenBIOS for a while, but
> with current kernel I get them all the time (probably because image
> became bigger).
>
> Signed-off-by: Eugene Surovegin <ebs@ebshome.net>
I wonder how that got lost when I think ENTRYPOINT was changed to
entrypoint-$(board_name). Maybe we should also think about changing the
default entry point in mktreeboot.c, what do you think Eugene? or Matt?
Acked-by: Tom Rini <trini@kernel.crashing.org>
--
Tom Rini
http://gate.crashing.org/~trini/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-11-28 22:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-24 21:38 [PATCH] ppc32: fix treeboot image entrypoint Eugene Surovegin
2005-11-28 22:34 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).