[PATCH] include/asm-ppc/btext.h: add prototype of btext_init function.

[PATCH] include/asm-ppc/btext.h: add prototype of btext_init function.

[Otavio Salvador]

The prototype of btext_init function was missing and then caused a compile
warning.

---

 include/asm-ppc/btext.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

applies-to: 60e8ae37378de2772b6b0768b12a49f923710152
786b869f9cfd4c1f82fbc8b20fa8cafb9188e12f
diff --git a/include/asm-ppc/btext.h b/include/asm-ppc/btext.h
index ccaefab..2329331 100644
--- a/include/asm-ppc/btext.h
+++ b/include/asm-ppc/btext.h
@@ -18,6 +18,7 @@ extern boot_infos_t disp_bi;
 extern int boot_text_mapped;
 
 extern void init_boot_display(void);
+extern void __init btext_init(boot_infos_t *bi);
 extern void btext_welcome(void);
 extern void btext_prepare_BAT(void);
 extern void btext_setup_display(int width, int height, int depth, int pitch,
---
0.99.9k

Re: [PATCH] include/asm-ppc/btext.h: add prototype of btext_init function.

[Eugene Surovegin]

On Sat, Dec 03, 2005 at 05:07:06PM -0200, Otavio Salvador wrote:
> The prototype of btext_init function was missing and then caused a compile
> warning.
> 
> ---
> 
>  include/asm-ppc/btext.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> applies-to: 60e8ae37378de2772b6b0768b12a49f923710152
> 786b869f9cfd4c1f82fbc8b20fa8cafb9188e12f
> diff --git a/include/asm-ppc/btext.h b/include/asm-ppc/btext.h
> index ccaefab..2329331 100644
> --- a/include/asm-ppc/btext.h
> +++ b/include/asm-ppc/btext.h
> @@ -18,6 +18,7 @@ extern boot_infos_t disp_bi;
>  extern int boot_text_mapped;
>  
>  extern void init_boot_display(void);
> +extern void __init btext_init(boot_infos_t *bi);
>  extern void btext_welcome(void);
>  extern void btext_prepare_BAT(void);
>  extern void btext_setup_display(int width, int height, int depth, int pitch,

"__init" should be placed between closing brace and semicolon. For 
more info, see include/linux/init.h

-- 
Eugene

Re: [PATCH] include/asm-ppc/btext.h: add prototype of btext_init function.

[Otavio Salvador]

Eugene Surovegin <ebs@ebshome.net> writes:

...
>> +extern void __init btext_init(boot_infos_t *bi);
...
>
> "__init" should be placed between closing brace and semicolon. For 
> more info, see include/linux/init.h

Ok. Thanks, I'll resend the patch.

-- 
        O T A V I O    S A L V A D O R
---------------------------------------------
 E-mail: otavio@debian.org      UIN: 5906116
 GNU/Linux User: 239058     GPG ID: 49A5F855
 Home Page: http://www.freedom.ind.br/otavio
---------------------------------------------
"Microsoft gives you Windows ... Linux gives
 you the whole house."

[PATCH] include/asm-ppc/btext.h: add prototype of btext_init function.

[Otavio Salvador]

The prototype of btext_init function was missing and then caused a compile
warning.

---

 include/asm-ppc/btext.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

applies-to: 60e8ae37378de2772b6b0768b12a49f923710152
19174aa31fd85e4410e99deb82c3b7ff2424fa55
diff --git a/include/asm-ppc/btext.h b/include/asm-ppc/btext.h
index ccaefab..2cf437c 100644
--- a/include/asm-ppc/btext.h
+++ b/include/asm-ppc/btext.h
@@ -18,6 +18,7 @@ extern boot_infos_t disp_bi;
 extern int boot_text_mapped;
 
 extern void init_boot_display(void);
+extern void btext_init(boot_infos_t *bi) __init;
 extern void btext_welcome(void);
 extern void btext_prepare_BAT(void);
 extern void btext_setup_display(int width, int height, int depth, int pitch,
---
0.99.9k

Re: [PATCH] include/asm-ppc/btext.h: add prototype of btext_init function.

[Andrew Morton]

Eugene Surovegin <ebs@ebshome.net> wrote:
>
>  > +extern void __init btext_init(boot_infos_t *bi);
>  >  extern void btext_welcome(void);
>  >  extern void btext_prepare_BAT(void);
>  >  extern void btext_setup_display(int width, int height, int depth, int pitch,
> 
>  "__init" should be placed between closing brace and semicolon. For 
>  more info, see include/linux/init.h

I don't think it matters much.  Often we just omit it from the declaration
- it's only required at the definition site

Re: [PATCH] include/asm-ppc/btext.h: add prototype of btext_init function.

[Eugene Surovegin]

On Sat, Dec 03, 2005 at 04:00:20PM -0800, Andrew Morton wrote:
> Eugene Surovegin <ebs@ebshome.net> wrote:
> >
> >  > +extern void __init btext_init(boot_infos_t *bi);
> >  >  extern void btext_welcome(void);
> >  >  extern void btext_prepare_BAT(void);
> >  >  extern void btext_setup_display(int width, int height, int depth, int pitch,
> > 
> >  "__init" should be placed between closing brace and semicolon. For 
> >  more info, see include/linux/init.h
> 
> I don't think it matters much.  Often we just omit it from the declaration
> - it's only required at the definition site

Quite likely it doesn't matter, but I think we should follow existing 
style, if not for correctness, but at least for consistency (it 
actually caught my eye exactly because it _looked_ different). I'm 
pretty sure original poster have tested original version :).

-- 
Eugene

Re: [PATCH] include/asm-ppc/btext.h: add prototype of btext_init function.

[Paul Mackerras]

Eugene Surovegin writes:

> "__init" should be placed between closing brace and semicolon. For 
> more info, see include/linux/init.h

Actually, there's no point putting __init in an extern declaration.

Paul.

Re: [PATCH] include/asm-ppc/btext.h: add prototype of btext_init function.

[Geert Uytterhoeven]

On Sat, 3 Dec 2005, Andrew Morton wrote:
> Eugene Surovegin <ebs@ebshome.net> wrote:
> >  > +extern void __init btext_init(boot_infos_t *bi);
> >  >  extern void btext_welcome(void);
> >  >  extern void btext_prepare_BAT(void);
> >  >  extern void btext_setup_display(int width, int height, int depth, int pitch,
> > 
> >  "__init" should be placed between closing brace and semicolon. For 
> >  more info, see include/linux/init.h
> 
> I don't think it matters much.  Often we just omit it from the declaration
> - it's only required at the definition site

IIRC, on Alpha it's needed/recommended on both, to allow the compiler to
optimize jumps to the same section?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds