From: Nathan Lynch <ntl@pobox.com>
To: Otavio Salvador <otavio@debian.org>
Cc: akpm@osdl.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] arch/ppc/kernel/idle.c: don't declare cpu variable in non-SMP kernels
Date: Sat, 3 Dec 2005 14:00:27 -0500 [thread overview]
Message-ID: <20051203190026.GA29537@localhost.localdomain> (raw)
In-Reply-To: <11336348593561-git-send-email-otavio@debian.org>
> diff --git a/arch/ppc/kernel/idle.c b/arch/ppc/kernel/idle.c
> index 821a75e..b23a979 100644
> --- a/arch/ppc/kernel/idle.c
> +++ b/arch/ppc/kernel/idle.c
> @@ -37,7 +37,9 @@
> void default_idle(void)
> {
> void (*powersave)(void);
> +#ifdef CONFIG_SMP
> int cpu = smp_processor_id();
> +#endif
Better to just move the declaration of cpu down to the ifdef'd else
block further down in the function as that's the only place it is
used.
prev parent reply other threads:[~2005-12-03 19:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-03 18:34 [PATCH] arch/ppc/kernel/idle.c: don't declare cpu variable in non-SMP kernels Otavio Salvador
2005-12-03 18:46 ` Andrew Morton
2005-12-05 4:12 ` Paul Mackerras
2005-12-03 19:00 ` Nathan Lynch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051203190026.GA29537@localhost.localdomain \
--to=ntl@pobox.com \
--cc=akpm@osdl.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=otavio@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).