From: Eugene Surovegin <ebs@ebshome.net>
To: Andrew Morton <akpm@osdl.org>
Cc: linuxppc-dev@ozlabs.org, otavio@debian.org
Subject: Re: [PATCH] include/asm-ppc/btext.h: add prototype of btext_init function.
Date: Sat, 3 Dec 2005 16:12:05 -0800 [thread overview]
Message-ID: <20051204001205.GA20763@gate.ebshome.net> (raw)
In-Reply-To: <20051203160020.42d1da3c.akpm@osdl.org>
On Sat, Dec 03, 2005 at 04:00:20PM -0800, Andrew Morton wrote:
> Eugene Surovegin <ebs@ebshome.net> wrote:
> >
> > > +extern void __init btext_init(boot_infos_t *bi);
> > > extern void btext_welcome(void);
> > > extern void btext_prepare_BAT(void);
> > > extern void btext_setup_display(int width, int height, int depth, int pitch,
> >
> > "__init" should be placed between closing brace and semicolon. For
> > more info, see include/linux/init.h
>
> I don't think it matters much. Often we just omit it from the declaration
> - it's only required at the definition site
Quite likely it doesn't matter, but I think we should follow existing
style, if not for correctness, but at least for consistency (it
actually caught my eye exactly because it _looked_ different). I'm
pretty sure original poster have tested original version :).
--
Eugene
next prev parent reply other threads:[~2005-12-04 0:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-03 19:07 [PATCH] include/asm-ppc/btext.h: add prototype of btext_init function Otavio Salvador
2005-12-03 21:24 ` Eugene Surovegin
2005-12-03 21:31 ` Otavio Salvador
2005-12-03 21:33 ` Otavio Salvador
2005-12-04 0:00 ` Andrew Morton
2005-12-04 0:12 ` Eugene Surovegin [this message]
2005-12-04 21:13 ` Geert Uytterhoeven
2005-12-04 2:21 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051204001205.GA20763@gate.ebshome.net \
--to=ebs@ebshome.net \
--cc=akpm@osdl.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=otavio@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).