From: Pantelis Antoniou <pantelis.antoniou@gmail.com>
To: Wolfgang Denk <wd@denx.de>
Cc: Robert Applebaum <rapplebaum@silicontkx.com>,
linuxppc-embedded@ozlabs.org
Subject: Re: [PATCH] Support 8xx based Silicon Turnkey XTc
Date: Tue, 6 Dec 2005 19:41:36 +0200 [thread overview]
Message-ID: <200512061941.37502.pantelis.antoniou@gmail.com> (raw)
In-Reply-To: <20051206160122.DC581353F5E@atlas.denx.de>
On Tuesday 06 December 2005 18:01, Wolfgang Denk wrote:
> Dear Pantelis,
>
> in message <200512052115.45858.pantelis.antoniou@gmail.com> you wrote:
> > Support of Silicon Turnkey's XTc.
>
> Ummm .. a few questions...
>
> > arch/ppc/platforms/stxxtc.h | 285 +++++++++++++
>
> Here you include a lot of inlined code, but I have problems finding
> out what it is good for. For example, there is a full-blown
> bit-banging SPI driver included which is nowhere referenced.
>
> Am I missing something, or should this be cleaned up a bit?
>
It is used in drivers not submitted at this point...
They'll be forthcoming when the time comes.
> > drivers/mtd/maps/stxxtc_nor.c | 326 +++++++++++++++
>
> I think it is not a good idea to embed spaces in the flash map names,
> as this will make it impossible to select such devices from the
> kernel command line which you seem to intend (at least you have
> CONFIG_MTD_CMDLINE_PARTS enabled in your default configuration) ?
>
>
Well, I guess you're right. Though I never used the kernel command
line for selecting the devices.
> And a design question: Why are you using the concatenating (NOR)
> flash driver? Why don't you simply map the flashes (in U-Boot) such
> that you have one contiguous region? That would make flash use in
> U-Boot much more convenient, too.
>
Unfortunately is not possible. Due to the way the flash is mapped on boot it
is not possible to have it continuous. Believe me I've tried :)
> Best regards,
>
> Wolfgang Denk
>
> --
> Software Engineering: Embedded and Realtime Systems, Embedded Linux
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
> Where would we be without rhetorical questions?
>
Regards
Pantelis
next prev parent reply other threads:[~2005-12-06 17:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-05 19:15 [PATCH] Support 8xx based Silicon Turnkey XTc Pantelis Antoniou
2005-12-06 15:36 ` Marcelo Tosatti
2005-12-06 17:02 ` Pantelis Antoniou
2005-12-06 16:01 ` Wolfgang Denk
2005-12-06 17:41 ` Pantelis Antoniou [this message]
2005-12-06 17:45 ` Dan Malek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200512061941.37502.pantelis.antoniou@gmail.com \
--to=pantelis.antoniou@gmail.com \
--cc=linuxppc-embedded@ozlabs.org \
--cc=rapplebaum@silicontkx.com \
--cc=wd@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).