From: Eugene Surovegin <ebs@ebshome.net>
To: "Ruslan V. Sushko" <rsushko@ru.mvista.com>
Cc: linuxppc-embedded@ozlabs.org
Subject: Re: Netpoll controller support for PPC EMAC driver
Date: Thu, 8 Dec 2005 10:01:26 -0800 [thread overview]
Message-ID: <20051208180126.GA20921@gate.ebshome.net> (raw)
In-Reply-To: <1134045255.28438.4.camel@mephisto.spb.rtsoft.ru>
On Thu, Dec 08, 2005 at 03:34:15PM +0300, Ruslan V. Sushko wrote:
> This patch adds netpoll controller support for PPC EMAC driver
>
> Signed-off-by: Ruslan V. Sushko <rsushko@ru.mvista.com>
NAK. Please see long discussion on netdev couple of months ago about
netpoll and how it is horribly broken.
In short, to implement netpoll support in EMAC driver requires full
locking re-do (all locks must be IRQ disabling). I'm not gonna do
this, because it's wrong approach.
If you want netpoll support, figure out a way to do this correctly,
without penalizing users of EMAC driver by switching to IRQ locks.
--
Eugene
prev parent reply other threads:[~2005-12-08 18:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-08 12:34 Netpoll controller support for PPC EMAC driver Ruslan V. Sushko
2005-12-08 14:57 ` John W. Linville
2005-12-08 17:13 ` Ruslan V. Sushko
2005-12-08 18:01 ` Eugene Surovegin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051208180126.GA20921@gate.ebshome.net \
--to=ebs@ebshome.net \
--cc=linuxppc-embedded@ozlabs.org \
--cc=rsushko@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).