From: Horst von Brand <vonbrand@inf.utfsm.cl>
To: Olof Johansson <olof@lixom.net>
Cc: dtor_core@ameritech.net, kernel-stuff@comcast.net,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
linux-input@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH 2.6 1/2] usb/input: Add relayfs support to appletouch driver
Date: Fri, 16 Dec 2005 14:29:47 -0300 [thread overview]
Message-ID: <200512161729.jBGHTlGR017130@laptop11.inf.utfsm.cl> (raw)
In-Reply-To: Message from Olof Johansson <olof@lixom.net> of "Thu, 15 Dec 2005 11:50:17 -0800." <20051215195017.GA7195@pb15.lixom.net>
Olof Johansson <olof@lixom.net> wrote:
Just saw this.
> On Thu, Dec 15, 2005 at 12:31:08AM +0100, Michael Hanselmann wrote:
> > diff -rup linux-2.6.15-rc5.orig/drivers/usb/input/appletouch.c b/drivers/usb/input/appletouch.c
> > --- linux-2.6.15-rc5.orig/drivers/usb/input/appletouch.c 2005-12-13 22:44:24.000000000 +0100
> > +++ b/drivers/usb/input/appletouch.c 2005-12-15 00:25:09.000000000 +0100
[...]
> > +#if defined(CONFIG_RELAYFS_FS) || defined(CONFIG_RELAYFS_FS_MODULE)
> > +#include <linux/relayfs_fs.h>
> > +#endif
Why can't this be included regardless? If it does something that only makes
sense if relayfs is in use, better have that decision inside the header
file (least somebody just includes it and...).
--
Dr. Horst H. von Brand User #22616 counter.li.org
Departamento de Informatica Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria +56 32 654239
Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513
prev parent reply other threads:[~2005-12-16 17:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-13 22:36 [PATCH 2.6 1/2] usb/input: Add relayfs support to appletouch driver Michael Hanselmann
2005-12-13 22:40 ` [PATCH 2.6 2/2] usb/input: Add Geyser 2 " Michael Hanselmann
2005-12-17 1:19 ` Michael Hanselmann
2005-12-14 13:57 ` [PATCH 2.6 1/2] usb/input: Add relayfs " Johannes Berg
2005-12-14 21:39 ` Michael Hanselmann
2005-12-14 22:04 ` Dmitry Torokhov
2005-12-14 23:31 ` Michael Hanselmann
2005-12-15 3:43 ` Dmitry Torokhov
2005-12-15 8:37 ` Michael Hanselmann
2005-12-15 19:50 ` Olof Johansson
2005-12-15 21:26 ` Michael Hanselmann
2005-12-15 21:38 ` Dmitry Torokhov
2005-12-16 17:29 ` Horst von Brand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200512161729.jBGHTlGR017130@laptop11.inf.utfsm.cl \
--to=vonbrand@inf.utfsm.cl \
--cc=dtor_core@ameritech.net \
--cc=kernel-stuff@comcast.net \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).