* mv643xx_eth, sleeping function called from invalid context at mm/slab.c:2472
@ 2005-12-19 13:39 Olaf Hering
0 siblings, 0 replies; 3+ messages in thread
From: Olaf Hering @ 2005-12-19 13:39 UTC (permalink / raw)
To: Manish_Lachwani, netdev; +Cc: linuxppc-dev
I get this with 2.6.15-rc6 on a pegasos2 board:
MV-643xx 10/100/1000 Ethernet Driver
eth1: port 1 with MAC address 00:2b:2f:de:ad:01
eth1: Scatter Gather Enabled
eth1: TX TCP/IP Checksumming Supported
eth1: RX TCP/UDP Checksum Offload ON
eth1: RX NAPI Enabled
eth1: Using SRAM
Debug: sleeping function called from invalid context at mm/slab.c:2472
in_atomic():0, irqs_disabled():1
Call Trace:
[CB32DCF0] [C000AFCC] show_stack+0x54/0x180 (unreliable)
[CB32DD10] [C0027CD4] __might_sleep+0xbc/0xd0
[CB32DD20] [C005E50C] kmem_cache_alloc+0x34/0x108
[CB32DD40] [C01C5F40] rand_initialize_irq+0x40/0x6c
[CB32DD60] [C0054104] setup_irq+0x5c/0x154
[CB32DD90] [C0054284] request_irq+0x88/0xb8
[CB32DDC0] [D22820A0] mv643xx_eth_open+0x44/0xb4 [mv643xx_eth]
[CB32DDE0] [C0257394] dev_open+0x70/0xd8
[CB32DE00] [C02554F0] dev_change_flags+0x6c/0x13c
[CB32DE20] [C02A2818] devinet_ioctl+0x280/0x708
[CB32DE80] [C02A319C] inet_ioctl+0xb4/0x100
[CB32DE90] [C02C0078] packet_ioctl+0x15c/0x188
[CB32DEB0] [C024B998] sock_ioctl+0x30c/0x334
[CB32DED0] [C00922F4] do_ioctl+0x3c/0x88
[CB32DEE0] [C0092728] vfs_ioctl+0x3e8/0x424
[CB32DF10] [C00927CC] sys_ioctl+0x68/0x98
[CB32DF40] [C000FAEC] ret_from_syscall+0x0/0x4c
--- Exception: c01 at 0x7f6be80
LR = 0x7fec9d0
eth1: no IPv6 routers present
00:00.0 Host bridge: Marvell Technology Group Ltd. MV64360/64361/64362 System Controller (rev 03)
00:01.0 FireWire (IEEE 1394): VIA Technologies, Inc. IEEE 1394 Host Controller (rev 46)
00:0c.0 ISA bridge: VIA Technologies, Inc. VT8231 [PCI-to-ISA Bridge] (rev 10)
00:0c.1 IDE interface: VIA Technologies, Inc. VT82C586A/B/VT82C686/A/B/VT823x/A/C PIPC Bus Master IDE (rev 06)
00:0c.2 USB Controller: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1 Controller (rev 1e)
00:0c.3 USB Controller: VIA Technologies, Inc. VT82xxxxx UHCI USB 1.1 Controller (rev 1e)
00:0c.4 Bridge: VIA Technologies, Inc. VT8235 ACPI (rev 10)
00:0c.5 Multimedia audio controller: VIA Technologies, Inc. VT82C686 AC97 Audio Controller (rev 40)
00:0c.6 Communication controller: VIA Technologies, Inc. AC'97 Modem Controller (rev 20)
00:0d.0 Ethernet controller: VIA Technologies, Inc. VT6102 [Rhine-II] (rev 51)
0001:01:00.0 Host bridge: Marvell Technology Group Ltd. MV64360/64361/64362 System Controller (rev 03)
0001:01:08.0 VGA compatible controller: ATI Technologies Inc RV280 [Radeon 9200 SE] (rev 01)
0001:01:08.1 Display controller: ATI Technologies Inc RV280 [Radeon 9200 SE] (Secondary) (rev 01)
--
short story of a lazy sysadmin:
alias appserv=wotan
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: mv643xx_eth, sleeping function called from invalid context at mm/slab.c:2472
@ 2005-12-28 22:49 Dale Farnsworth
2006-01-03 9:54 ` Olaf Hering
0 siblings, 1 reply; 3+ messages in thread
From: Dale Farnsworth @ 2005-12-28 22:49 UTC (permalink / raw)
To: linuxppc-dev; +Cc: olh
(For unknown reasons, I didn't receive this message directly from the
mailing list, and the archive doesn't seem to have message-ids, so
I can't supply a References: header.)
Olaf Hering reported:
> I get this with 2.6.15-rc6 on a pegasos2 board:
>
> MV-643xx 10/100/1000 Ethernet Driver
> eth1: port 1 with MAC address 00:2b:2f:de:ad:01
> eth1: Scatter Gather Enabled
> eth1: TX TCP/IP Checksumming Supported
> eth1: RX TCP/UDP Checksum Offload ON
> eth1: RX NAPI Enabled
> eth1: Using SRAM
> Debug: sleeping function called from invalid context at mm/slab.c:2472
> in_atomic():0, irqs_disabled():1
> Call Trace:
> [CB32DCF0] [C000AFCC] show_stack+0x54/0x180 (unreliable)
> [CB32DD10] [C0027CD4] __might_sleep+0xbc/0xd0
> [CB32DD20] [C005E50C] kmem_cache_alloc+0x34/0x108
> [CB32DD40] [C01C5F40] rand_initialize_irq+0x40/0x6c
> [CB32DD60] [C0054104] setup_irq+0x5c/0x154
> [CB32DD90] [C0054284] request_irq+0x88/0xb8
> [CB32DDC0] [D22820A0] mv643xx_eth_open+0x44/0xb4 [mv643xx_eth]
> [CB32DDE0] [C0257394] dev_open+0x70/0xd8
> [CB32DE00] [C02554F0] dev_change_flags+0x6c/0x13c
> [CB32DE20] [C02A2818] devinet_ioctl+0x280/0x708
> [CB32DE80] [C02A319C] inet_ioctl+0xb4/0x100
> [CB32DE90] [C02C0078] packet_ioctl+0x15c/0x188
> [CB32DEB0] [C024B998] sock_ioctl+0x30c/0x334
> [CB32DED0] [C00922F4] do_ioctl+0x3c/0x88
> [CB32DEE0] [C0092728] vfs_ioctl+0x3e8/0x424
> [CB32DF10] [C00927CC] sys_ioctl+0x68/0x98
> [CB32DF40] [C000FAEC] ret_from_syscall+0x0/0x4c
> --- Exception: c01 at 0x7f6be80
> LR = 0x7fec9d0
> eth1: no IPv6 routers present
I just posted the following patch to the netdev list which should address
this problem.
-Dale
Date: Wed, 28 Dec 2005 15:40:01 -0700
To: netdev@vger.kernel.org
Subject: [PATCH 4/4] mv643xx: Don't call request_irq with a held lock
Message-ID: <20051228224001.GD5742@xyzzy.farnsworth.org>
References: <20051228223449.GA5742@xyzzy.farnsworth.org>
From: Dale Farnsworth <dale@farnsworth.org>
We can't call request_irq() while holding a spin lock.
Signed-off-by: Dale Farnsworth <dale@farnsworth.org>
Index: linux-2.6-mv643xx_enet/drivers/net/mv643xx_eth.c
===================================================================
--- linux-2.6-mv643xx_enet.orig/drivers/net/mv643xx_eth.c
+++ linux-2.6-mv643xx_enet/drivers/net/mv643xx_eth.c
@@ -655,34 +655,24 @@ static int mv643xx_eth_open(struct net_d
unsigned int port_num = mp->port_num;
int err;
- spin_lock_irq(&mp->lock);
-
err = request_irq(dev->irq, mv643xx_eth_int_handler,
SA_SHIRQ | SA_SAMPLE_RANDOM, dev->name, dev);
-
if (err) {
printk(KERN_ERR "Can not assign IRQ number to MV643XX_eth%d\n",
port_num);
- err = -EAGAIN;
- goto out;
+ return -EAGAIN;
}
+ spin_lock_irq(&mp->lock);
+
if (mv643xx_eth_real_open(dev)) {
printk("%s: Error opening interface\n", dev->name);
+ free_irq(dev->irq, dev);
err = -EBUSY;
- goto out_free;
}
spin_unlock_irq(&mp->lock);
- return 0;
-
-out_free:
- free_irq(dev->irq, dev);
-
-out:
- spin_unlock_irq(&mp->lock);
-
return err;
}
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: mv643xx_eth, sleeping function called from invalid context at mm/slab.c:2472
2005-12-28 22:49 Dale Farnsworth
@ 2006-01-03 9:54 ` Olaf Hering
0 siblings, 0 replies; 3+ messages in thread
From: Olaf Hering @ 2006-01-03 9:54 UTC (permalink / raw)
To: Dale Farnsworth; +Cc: linuxppc-dev
On Wed, Dec 28, Dale Farnsworth wrote:
> (For unknown reasons, I didn't receive this message directly from the
> mailing list, and the archive doesn't seem to have message-ids, so
> I can't supply a References: header.)
This doesnt help:
MV-643xx 10/100/1000 Ethernet Driver
eth1: port 1 with MAC address 00:2b:2f:de:ad:01
eth1: Scatter Gather Enabled
eth1: TX TCP/IP Checksumming Supported
eth1: RX TCP/UDP Checksum Offload ON
eth1: RX NAPI Enabled
eth1: Using SRAM
Debug: sleeping function called from invalid context at mm/slab.c:2472
in_atomic():0, irqs_disabled():1
Call Trace:
[C3E01D40] [C000BCAC] show_stack+0x54/0x184 (unreliable)
[C3E01D60] [C0028E68] __might_sleep+0xbc/0xd0
[C3E01D70] [C005FD3C] __kmalloc+0x88/0x158
[C3E01D90] [D2281264] mv643xx_eth_real_open+0x15c/0x4b4 [mv643xx_eth]
[C3E01DC0] [D22820C0] mv643xx_eth_open+0x68/0xb0 [mv643xx_eth]
[C3E01DE0] [C025638C] dev_open+0x70/0xd8
[C3E01E00] [C02544F8] dev_change_flags+0x6c/0x13c
[C3E01E20] [C02A1838] devinet_ioctl+0x280/0x708
[C3E01E80] [C02A21BC] inet_ioctl+0xb4/0x100
[C3E01E90] [C02BF1A0] packet_ioctl+0x15c/0x188
[C3E01EB0] [C024A9A8] sock_ioctl+0x30c/0x334
[C3E01ED0] [C0093350] do_ioctl+0x3c/0x88
[C3E01EE0] [C0093784] vfs_ioctl+0x3e8/0x424
[C3E01F10] [C0093828] sys_ioctl+0x68/0x98
[C3E01F40] [C0010A60] ret_from_syscall+0x0/0x4c
--- Exception: c01 at 0x7f666e8
LR = 0x7f66680
eth1: no IPv6 routers present
--
short story of a lazy sysadmin:
alias appserv=wotan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-01-03 9:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-12-19 13:39 mv643xx_eth, sleeping function called from invalid context at mm/slab.c:2472 Olaf Hering
-- strict thread matches above, loose matches on Subject: below --
2005-12-28 22:49 Dale Farnsworth
2006-01-03 9:54 ` Olaf Hering
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).