From: Andrew Morton <akpm@osdl.org>
To: Kumar Gala <galak@gate.crashing.org>
Cc: dave@cray.org, linux-kernel@vger.kernel.org,
iinuxppc-embedded@gate.crashing.org, linuxppc-dev@ozlabs.org,
wim@iguana.be
Subject: Re: [PATCH] powerpc: Add support for the MPC83xx watchdog
Date: Fri, 13 Jan 2006 14:52:59 -0800 [thread overview]
Message-ID: <20060113145259.6d38e296.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.44.0601131618020.26648-100000@gate.crashing.org>
Kumar Gala <galak@gate.crashing.org> wrote:
>
> Added support for the PowerPC MPC83xx watchdog. The MPC83xx has a simple
> watchdog that once enabled it can not be stopped, has some simple timeout
> range selection, and the ability to either reset the processor or take
> a machine check.
>
>
> +static ushort timeout = 0xffff;
There's no such thing ;) I'll change this to u16, OK?
> +static int mpc83xx_wdt_ioctl(struct inode *inode, struct file *file,
> + unsigned int cmd,
> + unsigned long arg)
Whitespace went nutty in various places. I'll fix that up. Please see the
followup patch.
next prev parent reply other threads:[~2006-01-13 22:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-13 22:18 [PATCH] powerpc: Add support for the MPC83xx watchdog Kumar Gala
2006-01-13 22:52 ` Andrew Morton [this message]
2006-01-13 22:50 ` Kumar Gala
2006-01-13 22:58 ` Andrew Morton
2006-01-16 22:41 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060113145259.6d38e296.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=dave@cray.org \
--cc=galak@gate.crashing.org \
--cc=iinuxppc-embedded@gate.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).