From: Laurent Pinchart <laurent.pinchart@tbox.biz>
To: linuxppc-embedded@ozlabs.org
Subject: [RFC] arch/ppc/boot/simple/embed_boot.c : Merging all keyvals parsing code
Date: Wed, 25 Jan 2006 12:15:10 +0100 [thread overview]
Message-ID: <200601251215.10816.laurent.pinchart@tbox.biz> (raw)
Hi everybody,
the Embedded Planet boards boot loader pass a string containing key/value
pairs to the Linux loader code. That string is parsed in
arch/ppc/simple/embed_boot.c.
The current implementation duplicates the parsing code once for each supported
board. As I'm adding support for a new EP board (EP8248), I was wondering if
it would be worth merging all those parsers together. This would reduce the
source code size, but would be pointless at runtime as only one board support
code is compiled in the kernel anyway.
Should I submit a patch, or leave the code as it is ?
Laurent Pinchart
next reply other threads:[~2006-01-25 11:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-25 11:15 Laurent Pinchart [this message]
2006-01-25 15:48 ` [RFC] arch/ppc/boot/simple/embed_boot.c : Merging all keyvals parsing code Dan Malek
2006-01-25 16:02 ` Laurent Pinchart
2006-01-30 17:28 ` Tom Rini
2006-01-31 8:47 ` Laurent Pinchart
2006-01-31 14:24 ` Tom Rini
2006-01-31 20:31 ` Peter Korsgaard
2006-01-31 20:40 ` Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200601251215.10816.laurent.pinchart@tbox.biz \
--to=laurent.pinchart@tbox.biz \
--cc=linuxppc-embedded@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).