From: mita@miraclelinux.com (Akinobu Mita)
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: linux-m68k@vger.kernel.org, linux-ia64@vger.kernel.org,
ultralinux@vger.kernel.org,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
Andi Kleen <ak@suse.de>,
Linux/PPC Development <linuxppc-dev@ozlabs.org>,
'Geert Uytterhoeven' <geert@linux-m68k.org>,
sparclinux@vger.kernel.org, linux390@de.ibm.com,
linuxsh-dev@lists.sourceforge.net, parisc-linux@parisc-linux.org
Subject: Re: [PATCH 5/6] fix warning on test_ti_thread_flag()
Date: Thu, 26 Jan 2006 12:50:04 +0900 [thread overview]
Message-ID: <20060126035004.GA11543@miraclelinux.com> (raw)
In-Reply-To: <200601252002.k0PK2Mg31276@unix-os.sc.intel.com>
On Wed, Jan 25, 2006 at 12:02:21PM -0800, Chen, Kenneth W wrote:
> Geert Uytterhoeven wrote on Wednesday, January 25, 2006 9:19 AM
> > > I don't think you need to change the flags size.
> >
> > Passing a pointer to a 32-bit entity to a function that takes a
> > pointer to a 64-bit entity is a classical endianness bug. So it's
> > better to change it, before people copy the code to a big endian
> > platform.
>
> Well, x86-64 and linux-ia64 both use little endian. I don't
> understand why you are barking at us with big endian issue.
>
I can fix this without changing the flags size for those architectures.
1. Introduce *_le_bit() bit operations which takes void *addr
(already I have these functions in the scope of
HAVE_ARCH_EXT2_NON_ATOMIC_BITOPS in my patch)
2. Change flags to __u8 flags[4] or __u8 flags[8] for each architectures.
3. Use *_le_bit() in include/linux/thread_info.h
next prev parent reply other threads:[~2006-01-26 3:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-25 17:08 [PATCH 5/6] fix warning on test_ti_thread_flag() Chen, Kenneth W
2006-01-25 17:19 ` Geert Uytterhoeven
2006-01-25 20:02 ` Chen, Kenneth W
2006-01-26 3:50 ` Akinobu Mita [this message]
2006-01-26 4:12 ` Paul Mackerras
-- strict thread matches above, loose matches on Subject: below --
2006-01-25 11:26 [PATCH 0/6] RFC: use include/asm-generic/bitops.h Akinobu Mita
2006-01-25 11:34 ` [PATCH 5/6] fix warning on test_ti_thread_flag() Akinobu Mita
2006-01-25 12:28 ` Geert Uytterhoeven
2006-01-25 22:28 ` Paul Mackerras
2006-01-26 0:04 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060126035004.GA11543@miraclelinux.com \
--to=mita@miraclelinux.com \
--cc=ak@suse.de \
--cc=geert@linux-m68k.org \
--cc=kenneth.w.chen@intel.com \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux390@de.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=linuxsh-dev@lists.sourceforge.net \
--cc=parisc-linux@parisc-linux.org \
--cc=sparclinux@vger.kernel.org \
--cc=ultralinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).