* [PATCH] Don't check pointer for NULL before passing it to kfree [arch/powerpc/kernel/rtas_flash.c]
@ 2006-02-04 19:35 Jesper Juhl
0 siblings, 0 replies; only message in thread
From: Jesper Juhl @ 2006-02-04 19:35 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: linuxppc-dev
Checking a pointer for NULL before passing it to kfree is pointless, kfree
does its own NULL checking of input.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
arch/powerpc/kernel/rtas_flash.c | 3 +--
1 files changed, 1 insertion(+), 2 deletions(-)
--- linux-2.6.16-rc2-git1-orig/arch/powerpc/kernel/rtas_flash.c 2006-01-03 04:21:10.000000000 +0100
+++ linux-2.6.16-rc2-git1/arch/powerpc/kernel/rtas_flash.c 2006-02-04 20:30:21.000000000 +0100
@@ -672,8 +672,7 @@ static void rtas_flash_firmware(int rebo
static void remove_flash_pde(struct proc_dir_entry *dp)
{
if (dp) {
- if (dp->data != NULL)
- kfree(dp->data);
+ kfree(dp->data);
dp->owner = NULL;
remove_proc_entry(dp->name, dp->parent);
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-02-04 19:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-04 19:35 [PATCH] Don't check pointer for NULL before passing it to kfree [arch/powerpc/kernel/rtas_flash.c] Jesper Juhl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).