From: Olaf Hering <olh@suse.de>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] missing refcounting of of_find_node_by_name users
Date: Tue, 7 Feb 2006 11:58:28 +0100 [thread overview]
Message-ID: <20060207105828.GA30948@suse.de> (raw)
In-Reply-To: <17384.31565.896220.384684@cargo.ozlabs.ibm.com>
On Tue, Feb 07, Paul Mackeras wrote:
> This one isn't necessary, since np is NULL by the time we get out of
> the loop. Same applies to the other places in this file that this
> patch affects.
Ok.
> > Index: linux-2.6.16-rc2-olh/arch/powerpc/platforms/powermac/pci.c
> > ===================================================================
> > --- linux-2.6.16-rc2-olh.orig/arch/powerpc/platforms/powermac/pci.c
> > +++ linux-2.6.16-rc2-olh/arch/powerpc/platforms/powermac/pci.c
> > @@ -695,6 +695,7 @@ static void __init fixup_nec_usb2(void)
> > nec->intrs[0].line);
> > }
> > }
> > + of_put_node(nec);
>
> Once again, nec is NULL by the time we get here. And of_put_node
> doesn't exist. :( Did you compile-test this?
Only with a pegasos only config, which doesnt cover these files.
--
short story of a lazy sysadmin:
alias appserv=wotan
prev parent reply other threads:[~2006-02-07 10:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-18 15:18 Badness in kref_get at lib/kref.c:32, of_get_parent broken Olaf Hering
2006-02-04 11:55 ` [PATCH] add refcounting to setup_peg2 and of_get_pci_address Olaf Hering
2006-02-04 12:20 ` [PATCH] missing refcounting of of_find_node_by_name users Olaf Hering
2006-02-07 10:49 ` Paul Mackerras
2006-02-07 10:58 ` Olaf Hering [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060207105828.GA30948@suse.de \
--to=olh@suse.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).