linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] kprobes depends on xmon
@ 2006-02-14 13:10 Olaf Hering
  2006-02-14 19:54 ` Christoph Hellwig
  0 siblings, 1 reply; 3+ messages in thread
From: Olaf Hering @ 2006-02-14 13:10 UTC (permalink / raw)
  To: Paul Mackeras, linuxppc-dev


KPROBES depends on XMON.
arch/powerpc/lib/step.c is only compiled if CONFIG_XMON is enabled.

arch/powerpc/kernel/built-in.o:
In function `resume_execution':arch/powerpc/kernel/kprobes.c:331: undefined reference to
`.emulate_step'

Signed-off-by: Olaf Hering <olh@suse.de>

 arch/powerpc/Kconfig |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6.16-rc3-olh/arch/powerpc/Kconfig
===================================================================
--- linux-2.6.16-rc3-olh.orig/arch/powerpc/Kconfig
+++ linux-2.6.16-rc3-olh/arch/powerpc/Kconfig
@@ -963,7 +963,7 @@ source "arch/powerpc/oprofile/Kconfig"
 
 config KPROBES
 	bool "Kprobes (EXPERIMENTAL)"
-	depends on PPC64
+	depends on PPC64 && XMON
 	help
 	  Kprobes allows you to trap at almost any kernel address and
 	  execute a callback function.  register_kprobe() establishes

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] kprobes depends on xmon
  2006-02-14 13:10 [PATCH] kprobes depends on xmon Olaf Hering
@ 2006-02-14 19:54 ` Christoph Hellwig
  2006-02-14 21:26   ` [PATCH] kprobes needs emulate_step() Olaf Hering
  0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2006-02-14 19:54 UTC (permalink / raw)
  To: Olaf Hering; +Cc: linuxppc-dev

On Tue, Feb 14, 2006 at 02:10:50PM +0100, Olaf Hering wrote:
> 
> KPROBES depends on XMON.
> arch/powerpc/lib/step.c is only compiled if CONFIG_XMON is enabled.
> 
> arch/powerpc/kernel/built-in.o:
> In function `resume_execution':arch/powerpc/kernel/kprobes.c:331: undefined reference to
> `.emulate_step'

Please compile step.o if either CONFIG_KPROBES or CONFIG_XMON is defined
instead of adding a depency.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] kprobes needs emulate_step()
  2006-02-14 19:54 ` Christoph Hellwig
@ 2006-02-14 21:26   ` Olaf Hering
  0 siblings, 0 replies; 3+ messages in thread
From: Olaf Hering @ 2006-02-14 21:26 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: linuxppc-dev

 On Tue, Feb 14, Christoph Hellwig wrote:

> On Tue, Feb 14, 2006 at 02:10:50PM +0100, Olaf Hering wrote:
> > 
> > KPROBES depends on XMON.
> > arch/powerpc/lib/step.c is only compiled if CONFIG_XMON is enabled.
> > 
> > arch/powerpc/kernel/built-in.o:
> > In function `resume_execution':arch/powerpc/kernel/kprobes.c:331: undefined reference to
> > `.emulate_step'
> 
> Please compile step.o if either CONFIG_KPROBES or CONFIG_XMON is defined
> instead of adding a depency.
(This one seems to work without warning about duplicate object files or
something.)

KPROBES needs emulate_step()

arch/powerpc/kernel/built-in.o:
In function `resume_execution':arch/powerpc/kernel/kprobes.c:331: undefined reference to
`.emulate_step'

Signed-off-by: Olaf Hering <olh@suse.de>

 arch/powerpc/lib/Makefile |    1 +
 1 files changed, 1 insertion(+)

Index: linux-2.6.16-rc3-olh/arch/powerpc/lib/Makefile
===================================================================
--- linux-2.6.16-rc3-olh.orig/arch/powerpc/lib/Makefile
+++ linux-2.6.16-rc3-olh/arch/powerpc/lib/Makefile
@@ -12,6 +12,7 @@ obj-$(CONFIG_PPC64)	+= checksum_64.o cop
 			   memcpy_64.o usercopy_64.o mem_64.o string.o \
 			   strcase.o
 obj-$(CONFIG_PPC_ISERIES) += e2a.o
+obj-$(CONFIG_KPROBES)	+= sstep.o
 obj-$(CONFIG_XMON)	+= sstep.o
 
 ifeq ($(CONFIG_PPC64),y)

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2006-02-14 21:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-02-14 13:10 [PATCH] kprobes depends on xmon Olaf Hering
2006-02-14 19:54 ` Christoph Hellwig
2006-02-14 21:26   ` [PATCH] kprobes needs emulate_step() Olaf Hering

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).