From: Mark Fasheh <mark.fasheh@Oracle.com>
To: John Rose <johnrose@austin.ibm.com>
Cc: linuxppc-dev@ozlabs.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] move eeh_add_device_tree_late()
Date: Wed, 1 Mar 2006 09:59:22 -0800 [thread overview]
Message-ID: <20060301175922.GX20175@ca-server1.us.oracle.com> (raw)
In-Reply-To: <1141230954.19095.19.camel@sinatra.austin.ibm.com>
On Wed, Mar 01, 2006 at 10:35:55AM -0600, John Rose wrote:
> Good catch, Mark.
Heh, thanks.
> Commit 827c1a6c1a5dcb2902fecfb648f9af6a532934eb introduced a new
> function that calls eeh_add_device_late() implicitly. This patch
> reorders the two functions in question to fix the compile error. This
> might be preferable to exposing eeh_add_device_late() in eeh.h.
Hmm, you still left the EXPORT_SYMBOL(eeh_add_device_late) and you didn't
make eeh_add_device_late() static. Shouldn't you do that if you don't want
to make it accessible outside of eeh.c?
--Mark
--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@oracle.com
next prev parent reply other threads:[~2006-03-01 18:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060301001909.GU20175@ca-server1.us.oracle.com>
2006-03-01 1:02 ` [PATCH] powerpc: restore eeh_add_device_late() prototype Mark Fasheh
2006-03-01 16:35 ` [PATCH] move eeh_add_device_tree_late() John Rose
2006-03-01 17:59 ` Mark Fasheh [this message]
2006-03-01 18:57 ` John Rose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060301175922.GX20175@ca-server1.us.oracle.com \
--to=mark.fasheh@oracle.com \
--cc=johnrose@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).