From: Greg KH <greg@kroah.com>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
jesse.brandeburg@intel.com, linuxppc-dev@ozlabs.org,
john.ronciak@intel.com, jeffrey.t.kirsher@intel.com,
linux-pci@atrey.karlin.mff.cuni.cz,
Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH]: e1000: prevent statistics from getting garbled during reset.
Date: Thu, 30 Mar 2006 21:46:54 -0800 [thread overview]
Message-ID: <20060331054654.GA6632@kroah.com> (raw)
In-Reply-To: <20060331000208.GS2172@austin.ibm.com>
On Thu, Mar 30, 2006 at 06:02:08PM -0600, Linas Vepstas wrote:
> - /* Prevent stats update while adapter is being reset */
> + /* Prevent stats update while adapter is being reset,
> + * or if the pci connection is down. */
> if (adapter->link_speed == 0)
> return;
> + if (pdev->error_state && pdev->error_state != pci_channel_io_normal)
> + return;
Coding style is still wrong here :(
(hint, use a tab...)
thanks,
greg k-h
next prev parent reply other threads:[~2006-03-31 5:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-30 21:39 [PATCH]: e1000: prevent statistics from getting garbled during reset Linas Vepstas
2006-03-31 0:02 ` Linas Vepstas
2006-03-31 1:05 ` Jeff V. Merkey
2006-03-31 0:35 ` Linas Vepstas
2006-03-31 4:14 ` Jeffrey V. Merkey
2006-03-31 17:03 ` Linas Vepstas
2006-03-31 17:36 ` Rick Jones
2006-03-31 18:40 ` Jeff V. Merkey
2006-03-31 5:46 ` Greg KH [this message]
2006-03-31 17:06 ` Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060331054654.GA6632@kroah.com \
--to=greg@kroah.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jgarzik@pobox.com \
--cc=john.ronciak@intel.com \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).