From: Eugene Surovegin <ebs@ebshome.net>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@osdl.org>,
linuxppc-dev@ozlabs.org, Jan Beulich <jbeulich@novell.com>
Subject: "tvec_bases too large for per-cpu data" commit broke early_serial_setup()
Date: Sat, 1 Apr 2006 12:53:36 -0800 [thread overview]
Message-ID: <20060401205336.GA5748@gate.ebshome.net> (raw)
Hi!
Commit
a4a6198b80cf82eb8160603c98da218d1bd5e104
"[PATCH] tvec_bases too large for per-cpu data"
broke early_serial_setup() and maybe other code which uses
init_timer() before init_timers_cpu() is called.
This commit introduced run-time initialization dependence which never
existed before, namely, tvec_bases was always valid before this
change, but now it's a pointer which should be initialized prior to
use of any timer function.
If init_timer() is called before such initialization (in my case this
happens when PPC440GX board support code calls early_serial_setup to
register UARTs, serial8250_isa_init_ports() calls init_timer()),
"base" field in the timer_list struct is set to NULL.
When later mod_timer() is called for such timer it hangs in
lock_timer_base().
Rolling back this commit fixes the problem, although, this is
obviously not a proper fix.
I don't a fix I like, so I'll leave it to people more familiar with
this matter :)
--
Eugene
next reply other threads:[~2006-04-01 20:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-01 20:53 Eugene Surovegin [this message]
2006-04-01 22:06 ` "tvec_bases too large for per-cpu data" commit broke early_serial_setup() Andrew Morton
2006-04-01 22:32 ` Eugene Surovegin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060401205336.GA5748@gate.ebshome.net \
--to=ebs@ebshome.net \
--cc=akpm@osdl.org \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).