From: Arnd Bergmann <arnd.bergmann@de.ibm.com>
To: linuxppc-dev@ozlabs.org
Cc: Paul Mackerras <paulus@samba.org>
Subject: Re: [patch] powerpc: move PAGE_SIZE outside #ifdef __KERNEL__
Date: Thu, 20 Apr 2006 19:37:10 +0200 [thread overview]
Message-ID: <200604201937.10667.arnd.bergmann@de.ibm.com> (raw)
In-Reply-To: <4447C3BA.6050709@am.sony.com>
On Thursday 20 April 2006 19:24, Geoff Levand wrote:
> The procps package needs PAGE_SIZE, defined in asm-powerpc/page.h,
> but it is defined inside "#ifdef __KERNEL__".
>
> This moves the PAGE_SIZE definition outside of "#ifdef __KERNEL__".
>
> From: Hiroaki Fuse
> Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
Nack.
It's a little harder unfortunately. First of all, the patch moves
more parts outside of __KERNEL__, like the #include <linux/config.h>,
which does not get installed into /usr/include/linux/.
More importantly, the page size is no longer constant on powerpc
across kernel builds. User space relying on a fixed size is broken.
Please look into the sysconf(3) and getpagesize(2) man pages for
how to do it correctly.
Which version of procps are you referring to anyway? This bug seems
to have been fixed back in 2001, but maybe it got reintroduced now.
Arnd <><
next prev parent reply other threads:[~2006-04-20 17:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-20 17:24 [patch] powerpc: move PAGE_SIZE outside #ifdef __KERNEL__ Geoff Levand
2006-04-20 17:31 ` David Howells
2006-04-20 17:37 ` Arnd Bergmann [this message]
2006-04-20 18:00 ` Geoff Levand
2006-04-20 20:59 ` Benjamin Herrenschmidt
2006-04-20 23:07 ` Paul Mackerras
2006-04-21 15:23 ` Geoff Levand
2006-04-21 17:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200604201937.10667.arnd.bergmann@de.ibm.com \
--to=arnd.bergmann@de.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).