From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Heiko J Schick <schihei@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, openib-general@openib.org,
linuxppc-dev@ozlabs.org, Christoph Raisch <RAISCH@de.ibm.com>,
Hoang-Nam Nguyen <HNGUYEN@de.ibm.com>,
Marcus Eder <MEDER@de.ibm.com>
Subject: Re: [PATCH 05/16] ehca: InfiniBand query and multicast functionality
Date: Thu, 27 Apr 2006 13:41:04 +0200 [thread overview]
Message-ID: <20060427114104.GA32127@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <4450A17D.4030708@de.ibm.com>
Some small stuff.
On Thu, 27 April 2006 12:48:29 +0200, Heiko J Schick wrote:
>
> + * This source code is distributed under a dual license of GPL v2.0 and
> OpenIB
Line wrap. You might want to check your mailer or switch to a
different one.
> + return (-EINVAL);
Remove brackets.
> + if (H_SUCCESS != hipz_rc) {
To frown upon reversed grammar, I tend. Hard to understand, such code
is.
With a decent compiler, there is zero advantage to put the constant
first - assuming you don't ignore warnings. But it makes the code
just as hard to read as the Yoda-speak above.
> + return retcode;
People tend to use the shorter "ret" or "err".
Jörn
--
You can take my soul, but not my lack of enthusiasm.
-- Wally
next prev parent reply other threads:[~2006-04-27 11:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-27 10:48 [PATCH 05/16] ehca: InfiniBand query and multicast functionality Heiko J Schick
2006-04-27 11:41 ` Jörn Engel [this message]
2006-04-27 12:05 ` Arnd Bergmann
2006-04-27 12:16 ` Jörn Engel
2006-04-27 13:45 ` Christoph Hellwig
2006-04-27 14:39 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060427114104.GA32127@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=HNGUYEN@de.ibm.com \
--cc=MEDER@de.ibm.com \
--cc=RAISCH@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=openib-general@openib.org \
--cc=schihei@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).