From: Nathan Lynch <ntl@pobox.com>
To: Jimi Xenidis <jimix@pobox.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [patch] udb_printf() formatting attribute
Date: Wed, 17 May 2006 11:00:53 -0500 [thread overview]
Message-ID: <20060517160053.GE10310@localdomain> (raw)
In-Reply-To: <4025245D-6BAB-41D3-ADB6-2748741F223E@watson.ibm.com>
Jimi Xenidis wrote:
> This patch allows the compiler to catch any printf-like mismatches
> for udbg_printf().
> After some brute force building I've only found issues with my own
> code and lparcfg.c
> It could break some developers, but IMHO that would be goodness.
>
> Signed-off-by: Jimi Xenidis <jimix@watson.ibm.com>
> ---
> diff -r 0163968f7fce arch/powerpc/kernel/lparcfg.c
> --- a/arch/powerpc/kernel/lparcfg.c Tue May 16 15:55:19 2006 -0400
> +++ b/arch/powerpc/kernel/lparcfg.c Wed May 17 10:43:55 2006 -0400
> @@ -521,10 +521,10 @@ static ssize_t lparcfg_write(struct file
> current_weight = (resource >> 5 * 8) & 0xFF;
> - pr_debug("%s: current_entitled = %lu, current_weight = %lu\n",
> + pr_debug("%s: current_entitled = %lu, current_weight = %u\n",
> __FUNCTION__, current_entitled, current_weight);
> - pr_debug("%s: new_entitled = %lu, new_weight = %lu\n",
> + pr_debug("%s: new_entitled = %lu, new_weight = %u\n",
> __FUNCTION__, *new_entitled_ptr, *new_weight_ptr);
> retval = plpar_hcall_norets(H_SET_PPP, *new_entitled_ptr,
Does this really fix a bug? What warnings are you able to get gcc to
emit?
next prev parent reply other threads:[~2006-05-17 16:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-17 15:04 [patch] udb_printf() formatting attribute Jimi Xenidis
2006-05-17 16:00 ` Nathan Lynch [this message]
2006-05-17 18:30 ` Jimi Xenidis
2006-05-17 18:31 ` Jimi Xenidis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060517160053.GE10310@localdomain \
--to=ntl@pobox.com \
--cc=jimix@pobox.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).