From: Tom Rini <trini@kernel.crashing.org>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linuxppc-dev <Linuxppc-dev@ozlabs.org>
Subject: Re: [HACK] add sandpoint + flattened dt support to arch/powerpc/boot
Date: Mon, 22 May 2006 15:22:27 -0700 [thread overview]
Message-ID: <20060522222227.GR32112@smtp.west.cox.net> (raw)
In-Reply-To: <1147999765.8515.6.camel@localhost.localdomain>
On Fri, May 19, 2006 at 10:49:25AM +1000, Michael Ellerman wrote:
> On Thu, 2006-05-18 at 17:37 -0700, Mark A. Greer wrote:
> > On Thu, May 18, 2006 at 08:47:01AM -0500, Matthew McClintock wrote:
> > > On Wed, 2006-05-17 at 17:21 -0700, Mark A. Greer wrote:
> > > > +void *
> > > > +dt_find_prop_by_name(void *dt_blob, char *full_name, u32 *val_sizep)
> > >
> > > Is there a reason you are not using of_get_flat_dt_prop() instead of
> > > implementing your own version?
> >
> > Yes. One is in the kernel, one isn't. Or, are you asking why I didn't
> > just copy the kernel code? If so, I probably should have.
> >
> > Hrm, we almost need a library of code shared between the kernel &
> > the bootwrapper. Sort of illegal but it would save duplicating code
> > like the flat dt code.
> >
> > Comments?
>
> Yeah we do. And it's not illegal IMHO as two of our boot wrappers
> (prom_init and the iSeries one) are linked with the kernel anyway.
And on all architectures (practically) the zlib inflate code is shared
between kernel and bootstuff. So it's not unprecidented to do the ugly
define abstractions to let you easily share code as needed.
--
Tom Rini
next prev parent reply other threads:[~2006-05-22 22:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-18 0:21 [HACK] add sandpoint + flattened dt support to arch/powerpc/boot Mark A. Greer
2006-05-18 5:32 ` Benjamin Herrenschmidt
2006-05-18 13:52 ` Matthew McClintock
2006-05-26 6:03 ` Benjamin Herrenschmidt
2006-05-23 0:58 ` Mark A. Greer
2006-05-23 1:13 ` Tom Rini
2006-07-19 20:02 ` Guennadi Liakhovetski
2006-07-19 22:10 ` Mark A. Greer
2006-07-19 22:29 ` Guennadi Liakhovetski
2006-07-20 0:39 ` Mark A. Greer
2006-06-14 3:37 ` Mark A. Greer
2006-05-18 13:47 ` Matthew McClintock
2006-05-19 0:37 ` Mark A. Greer
2006-05-19 0:49 ` Michael Ellerman
2006-05-22 22:22 ` Tom Rini [this message]
2006-06-05 20:41 ` Matthew McClintock
2006-06-05 21:04 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060522222227.GR32112@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=Linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).