From: Michael Neuling <mikey@neuling.org>
To: Segher Boessenkool <segher@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH] powerpc: oprofile support for POWER6
Date: Thu, 08 Jun 2006 14:29:01 +1000 [thread overview]
Message-ID: <20060608042915.C568867B1A@ozlabs.org> (raw)
In-Reply-To: <4AE0F2C6-99B7-40AF-AB28-71D51C1141A5@kernel.crashing.org>
> > /*
> > - * SIHV / SIPR bits are only implemented on POWER4+ (GQ) and above.
> > - * However we disable it on all POWER4 until we verify it works
> > - * (I was seeing some strange behaviour last time I tried).
> > - *
> > - * It has been verified to work on POWER5 so we enable it there.
> > - */
>
> The patched code doesn't handle GQ at all. Is this on purpose? Add a
> similar comment to the CPU feature tables perhaps?
Yeah, those bits are bust on POWER4+. We didn't touch them previously
and we still don't with this patch.
You're right, we should keep that comment. I'll update and retransmit.
Mikey
next prev parent reply other threads:[~2006-06-08 4:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-07 1:23 [PATCH] powerpc: oprofile support for POWER6 Michael Neuling
2006-06-07 22:59 ` Segher Boessenkool
2006-06-08 4:29 ` Michael Neuling [this message]
2006-06-09 19:03 ` Sonny Rao
-- strict thread matches above, loose matches on Subject: below --
2006-06-08 4:42 Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060608042915.C568867B1A@ozlabs.org \
--to=mikey@neuling.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).