From: Laurent Pinchart <laurent.pinchart@tbox.biz>
To: Vitaly Bordug <vbordug@ru.mvista.com>
Cc: linuxppc-embedded <linuxppc-embedded@ozlabs.org>
Subject: Re: CPM_UART should allocate DPRAM for SMCx parameter RAM on MPC82xx
Date: Mon, 12 Jun 2006 13:43:37 +0200 [thread overview]
Message-ID: <200606121343.37972.laurent.pinchart@tbox.biz> (raw)
In-Reply-To: <20060610030950.1a690abb@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 482 bytes --]
Hi Vitaly,
> If and when you'll have some code that address your problem, submit it
> to me cc linuxppc-embedded, and I'll push it upstream.
here's a simple patch (against 2.6.17-rc6) that fixes the issue by modifying
the pram addresses for SMC resources. I'm not completely satisfied, as the
SMCx_BASE registers configuration is board-specific (must be handled in
init_ioports as you mentionned in your previous e-mail), which will lead to
duplicated code.
Laurent Pinchart
[-- Attachment #2: pq2_devices.diff --]
[-- Type: text/x-diff, Size: 1047 bytes --]
diff --git a/arch/ppc/syslib/pq2_devices.c b/arch/ppc/syslib/pq2_devices.c
index fefbc21..0a7082e 100644
--- a/arch/ppc/syslib/pq2_devices.c
+++ b/arch/ppc/syslib/pq2_devices.c
@@ -289,15 +289,15 @@ struct platform_device ppc_sys_platform_
.num_resources = 3,
.resource = (struct resource[]) {
{
- .name = "smc_mem",
+ .name = "regs",
.start = 0x11A80,
.end = 0x11A8F,
.flags = IORESOURCE_MEM,
},
{
- .name = "smc_pram",
- .start = 0x87fc,
- .end = 0x87fd,
+ .name = "pram",
+ .start = 0x0000,
+ .end = 0x003f,
.flags = IORESOURCE_MEM,
},
{
@@ -313,15 +313,15 @@ struct platform_device ppc_sys_platform_
.num_resources = 3,
.resource = (struct resource[]) {
{
- .name = "smc_mem",
+ .name = "regs",
.start = 0x11A90,
.end = 0x11A9F,
.flags = IORESOURCE_MEM,
},
{
- .name = "smc_pram",
- .start = 0x88fc,
- .end = 0x88fd,
+ .name = "pram",
+ .start = 0x0040,
+ .end = 0x007f,
.flags = IORESOURCE_MEM,
},
{
prev parent reply other threads:[~2006-06-12 11:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-07 12:34 CPM_UART should allocate DPRAM for SMCx parameter RAM on MPC82xx Laurent Pinchart
2006-06-07 13:31 ` Vitaly Bordug
2006-06-07 13:39 ` Laurent Pinchart
2006-06-07 13:49 ` Vitaly Bordug
2006-06-07 14:10 ` *** PROBABLY SPAM *** " Laurent Pinchart
2006-06-07 16:34 ` Dan Malek
[not found] ` <200606071629.19136.laurent.pinchart@tbox.biz>
[not found] ` <20060610030950.1a690abb@localhost.localdomain>
2006-06-12 11:43 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200606121343.37972.laurent.pinchart@tbox.biz \
--to=laurent.pinchart@tbox.biz \
--cc=linuxppc-embedded@ozlabs.org \
--cc=vbordug@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).