From: mel@skynet.ie (Mel Gorman)
To: David Howells <dhowells@redhat.com>
Cc: akpm@osdl.org, davej@codemonkey.org.uk, tony.luck@intel.com,
linuxppc-dev@ozlabs.org, ak@suse.de, bob.picco@hp.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 6/6] Account for memmap and optionally the kernel image as holes
Date: Mon, 10 Jul 2006 16:31:30 +0100 [thread overview]
Message-ID: <20060710153129.GA26077@skynet.ie> (raw)
In-Reply-To: <7220.1152531055@warthog.cambridge.redhat.com>
On (10/07/06 12:30), David Howells didst pronounce:
> Mel Gorman <mel@csn.ul.ie> wrote:
>
> > +unsigned long __initdata dma_reserve;
>
> Should this be static? Or should it be predeclared in a header file
> somewhere?
>
It should be static as it's set by set_dma_reserve(). Thanks.
diff -rup -X /usr/src/patchset-0.6/bin//dontdiff linux-2.6.17-mm6-106-account_kernel_mmap/mm/page_alloc.c linux-2.6.17-mm6-107-fixstatic/mm/page_alloc.c
--- linux-2.6.17-mm6-106-account_kernel_mmap/mm/page_alloc.c 2006-07-10 15:55:09.000000000 +0100
+++ linux-2.6.17-mm6-107-fixstatic/mm/page_alloc.c 2006-07-10 16:03:26.000000000 +0100
@@ -87,7 +87,7 @@ int min_free_kbytes = 1024;
unsigned long __meminitdata nr_kernel_pages;
unsigned long __meminitdata nr_all_pages;
-unsigned long __initdata dma_reserve;
+static unsigned long __initdata dma_reserve;
#ifdef CONFIG_ARCH_POPULATES_NODE_MAP
/*
next prev parent reply other threads:[~2006-07-10 16:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-08 11:10 [PATCH 0/6] Sizing zones and holes in an architecture independent manner V8 Mel Gorman
2006-07-08 11:11 ` [PATCH 1/6] Introduce mechanism for registering active regions of memory Mel Gorman
2006-07-08 11:11 ` [PATCH 2/6] Have Power use add_active_range() and free_area_init_nodes() Mel Gorman
2006-07-08 11:11 ` [PATCH 3/6] Have x86 use add_active_range() and free_area_init_nodes Mel Gorman
2006-07-08 11:12 ` [PATCH 4/6] Have x86_64 " Mel Gorman
2006-07-08 11:12 ` [PATCH 5/6] Have ia64 " Mel Gorman
2006-07-08 11:12 ` [PATCH 6/6] Account for memmap and optionally the kernel image as holes Mel Gorman
2006-07-08 11:42 ` [PATCH 0/6] Sizing zones and holes in an architecture independent manner V8 Heiko Carstens
2006-07-09 15:32 ` Mel Gorman
2006-07-10 11:30 ` [PATCH 6/6] Account for memmap and optionally the kernel image as holes David Howells
2006-07-10 15:31 ` Mel Gorman [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-08-21 13:45 [PATCH 0/6] Sizing zones and holes in an architecture independent manner V9 Mel Gorman
2006-08-21 13:47 ` [PATCH 6/6] Account for memmap and optionally the kernel image as holes Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060710153129.GA26077@skynet.ie \
--to=mel@skynet.ie \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=bob.picco@hp.com \
--cc=davej@codemonkey.org.uk \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).