From: Arnd Bergmann <arnd.bergmann@de.ibm.com>
To: linuxppc-dev@ozlabs.org
Cc: Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 1/6] bootwrapper: arch/powerpc/boot code reorg
Date: Wed, 2 Aug 2006 14:41:23 +0200 [thread overview]
Message-ID: <200608021441.23429.arnd.bergmann@de.ibm.com> (raw)
In-Reply-To: <17616.12251.339657.215571@cargo.ozlabs.ibm.com>
On Wednesday 02 August 2006 06:53, Paul Mackerras wrote:
> > +#ifdef __powerpc64__
> > +typedef unsigned long=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0u=
64;
> > +#else
> > +typedef unsigned long long=A0=A0=A0u64;
> > +#endif
>=20
> This is potentially confusing, because the __powerpc64__ relates to
> the boot wrapper not the kernel, and we don't build a 64-bit boot
> wrapper on any platform (not yet anyway). =A0Maybe this needs a comment.
>=20
Moreover, even if we ever build this on __powerpc64__, the=20
typedef unsigned long long u64 would still do the right thing.
It only ever becomes a problem when mixing with u64 the c99 uint64_t,
which is defined the other way.
Arnd <><
next prev parent reply other threads:[~2006-08-02 12:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-19 23:00 [PATCH 1/6] bootwrapper: arch/powerpc/boot code reorg Mark A. Greer
2006-08-02 4:53 ` Paul Mackerras
2006-08-02 6:15 ` Paul Mackerras
2006-08-02 16:03 ` Tom Rini
2006-08-02 16:58 ` Mark A. Greer
2006-08-03 19:26 ` Mark A. Greer
2006-08-07 6:48 ` Paul Mackerras
2006-08-08 0:15 ` Mark A. Greer
2006-08-02 12:41 ` Arnd Bergmann [this message]
2006-08-02 17:00 ` Mark A. Greer
2006-08-02 16:40 ` Mark A. Greer
2006-08-07 0:21 ` Hollis Blanchard
2006-08-08 0:16 ` Mark A. Greer
2006-09-08 3:35 ` Mark A. Greer
2006-09-15 10:19 ` Paul Mackerras
2006-09-15 18:01 ` Mark A. Greer
2006-09-16 4:01 ` Paul Mackerras
2006-09-19 0:45 ` Mark A. Greer
2006-09-19 0:48 ` Mark A. Greer
-- strict thread matches above, loose matches on Subject: below --
2006-08-03 5:57 Milton Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608021441.23429.arnd.bergmann@de.ibm.com \
--to=arnd.bergmann@de.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).