From: Mike Kravetz <kravetz@us.ibm.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [RFC] asm code for Hypervisor Call Instrumentation
Date: Thu, 3 Aug 2006 10:40:58 -0700 [thread overview]
Message-ID: <20060803174058.GA3179@w-mikek2.ibm.com> (raw)
In-Reply-To: <20060803040506.GB3484@monkey.ibm.com>
On Wed, Aug 02, 2006 at 09:05:06PM -0700, Mike Kravetz wrote:
> On Thu, Aug 03, 2006 at 01:57:17PM +1000, Stephen Rothwell wrote:
> > On Wed, 2 Aug 2006 10:59:47 -0700 Mike Kravetz <kravetz@us.ibm.com> wrote:
> > > +#else
> > > +
> > > +#define STACKFRAMESIZE 0
> > > +#define HCALL_INST_PRECALL nop
> > > +#define HCALL_INST_POSTCALL nop
> >
> > Why even "nop", why not just blank?
>
> At first I was concerned about macro expansion and knew a 'nop'
> would be ok. Intended to go back and try 'blank', but forgot.
> I'll give it a try.
What is the preferred method to 'leave it blank'?
#define HCALL_INST_PRECALL /* nop */
#define HCALL_INST_PRECALL ;
something else?
Leaving HCALL_INST_PRECALL undefined results in an assembler error.
--
Mike
next prev parent reply other threads:[~2006-08-03 17:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-02 17:59 [RFC] asm code for Hypervisor Call Instrumentation Mike Kravetz
2006-08-03 3:57 ` Stephen Rothwell
2006-08-03 4:05 ` Mike Kravetz
2006-08-03 17:40 ` Mike Kravetz [this message]
2006-08-03 23:25 ` Stephen Rothwell
2006-08-04 0:08 ` Mike Kravetz
2006-08-07 6:26 ` Paul Mackerras
2006-08-11 18:30 ` Mike Kravetz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060803174058.GA3179@w-mikek2.ibm.com \
--to=kravetz@us.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).