* [PATCH] pSeries hvsi char driver janitorial cleanup.
@ 2006-08-03 19:36 Linas Vepstas
2006-08-03 21:06 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Linas Vepstas @ 2006-08-03 19:36 UTC (permalink / raw)
To: akpm, hollisbl; +Cc: linuxppc-dev, linux-kernel
Andrew,
Please apply.
A set of tty line discipline cleanup patches were introduced
before the dawn of time, in kernel version 2.4.21. This patch
performs that cleanup for the hvsi driver.
The hvsi driver is used only on IBM pSeries PowerPC boxes.
The driver was originally written by Hollis Blanchard, who
has delegated maintainership to me. So this my first and
maybe only patch in this official new role, because this
driver is otherwise bug-free :-)
Signed-off-by: Linas Vepstas <linas@austin.ibm.com>
----
drivers/char/hvsi.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
Index: linux-2.6.18-rc3-git1/drivers/char/hvsi.c
===================================================================
--- linux-2.6.18-rc3-git1.orig/drivers/char/hvsi.c 2006-08-01 14:26:38.000000000 -0500
+++ linux-2.6.18-rc3-git1/drivers/char/hvsi.c 2006-08-01 15:03:12.000000000 -0500
@@ -986,10 +986,7 @@ static void hvsi_write_worker(void *arg)
start_j = 0;
#endif /* DEBUG */
wake_up_all(&hp->emptyq);
- if (test_bit(TTY_DO_WRITE_WAKEUP, &hp->tty->flags)
- && hp->tty->ldisc.write_wakeup)
- hp->tty->ldisc.write_wakeup(hp->tty);
- wake_up_interruptible(&hp->tty->write_wait);
+ tty_wakeup(hp->tty);
}
out:
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] pSeries hvsi char driver janitorial cleanup.
2006-08-03 19:36 [PATCH] pSeries hvsi char driver janitorial cleanup Linas Vepstas
@ 2006-08-03 21:06 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2006-08-03 21:06 UTC (permalink / raw)
To: Linas Vepstas; +Cc: akpm, hollisbl, linux-kernel, linuxppc-dev
Ar Iau, 2006-08-03 am 14:36 -0500, ysgrifennodd Linas Vepstas:
> Andrew,
> Please apply.
>
> A set of tty line discipline cleanup patches were introduced
> before the dawn of time, in kernel version 2.4.21. This patch
> performs that cleanup for the hvsi driver.
Actually its also a bug fix, tty->ldisc should be locked by refcounting
and the helpers do this for you.
Acked-by: Alan Cox <alan@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-08-03 20:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-03 19:36 [PATCH] pSeries hvsi char driver janitorial cleanup Linas Vepstas
2006-08-03 21:06 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).