From: danny@mailmij.org
To: Paul Mackerras <paulus@samba.org>
Cc: danny@mailmij.org, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] fix for firewire patch added in 2.6.17.2 that breaks things on ppc
Date: Tue, 8 Aug 2006 07:37:03 +0200 [thread overview]
Message-ID: <20060808073703.A13937@luna.ellen.dexterslabs.com> (raw)
In-Reply-To: <17624.7051.905145.470927@cargo.ozlabs.ibm.com>; from paulus@samba.org on Tue, Aug 08, 2006 at 03:05:15PM +1000
On Tue, Aug 08, 2006 at 03:05:15PM +1000, Paul Mackerras wrote:
> danny@mailmij.org writes:
>
> > -#endif
> > -
> > +#else
> > pci_save_state(pdev);
> > -
> > +#endif /* CONFIG_PPC_PMAC */
>
> Shouldn't we just move the pci_save_state call up before the
> pmac_call_feature() call?
>
I can do a rebuild tonight or so to test this. But since it was working perfectly before I did not see
any reason to keep it.
Danny
next prev parent reply other threads:[~2006-08-08 5:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060805151050.B24484@luna.ellen.dexterslabs.com>
2006-08-07 4:38 ` [PATCH] fix for firewire patch added in 2.6.17.2 that breaks things on ppc danny
2006-08-08 5:05 ` Paul Mackerras
2006-08-08 5:37 ` danny [this message]
2006-08-08 16:50 ` danny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060808073703.A13937@luna.ellen.dexterslabs.com \
--to=danny@mailmij.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox