From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: Thomas Klein <osstklei@de.ibm.com>
Cc: Thomas Klein <tklein@de.ibm.com>,
Michael Neuling <mikey@neuling.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Raisch <raisch@de.ibm.com>,
linuxppc-dev@ozlabs.org, Marcus Eder <meder@de.ibm.com>,
Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: [PATCH 3/6] ehea: queue management
Date: Fri, 11 Aug 2006 11:21:32 +0200 [thread overview]
Message-ID: <20060811092132.GA4137@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <44DC319A.10802@de.ibm.com>
On Fri, 11 August 2006 09:28:26 +0200, Thomas Klein wrote:
> Michael Neuling wrote:
> >>>>+static inline u32 map_swqe_size(u8 swqe_enc_size)
> >>>>+static inline u32|map_rwqe_size(u8 rwqe_enc_size)
> >
> Agreed. Functions were replaced by a single map_wqe_size() function.
Just a general thing, try to avoid having two identifiers that are
near-100% identical. As seen in this thread, they are _very_ easy to
confuse.
Ime, there are two methods to avoid this. One is to make the
identifiers longer, something like "map_seek_wqe_size" and
"map_read_wqe_size". The other is to make them shorter, just "s" and
"r" is less confusing than the above.
Which method works best depends on many things, including personal
taste.
Jörn
--
And spam is a useful source of entropy for /dev/random too!
-- Jasmine Strong
next prev parent reply other threads:[~2006-08-11 9:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-09 8:39 [PATCH 3/6] ehea: queue management Jan-Bernd Themann
2006-08-11 0:05 ` Michael Neuling
2006-08-11 0:32 ` Alexey Dobriyan
2006-08-11 0:46 ` Michael Neuling
2006-08-11 7:28 ` Thomas Klein
2006-08-11 9:21 ` Jörn Engel [this message]
2006-08-11 13:04 ` Jan-Bernd Themann
2006-08-11 16:09 ` Thomas Klein
2006-08-11 21:52 ` Anton Blanchard
2006-08-12 16:37 ` Thomas Klein
2006-08-13 14:44 ` Anton Blanchard
2006-08-14 12:38 ` ehea debug output discussion Jan-Bernd Themann
2006-08-15 0:02 ` Michael Ellerman
2006-08-15 5:10 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060811092132.GA4137@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=meder@de.ibm.com \
--cc=mikey@neuling.org \
--cc=netdev@vger.kernel.org \
--cc=osstklei@de.ibm.com \
--cc=raisch@de.ibm.com \
--cc=tklein@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).