From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sat, 12 Aug 2006 07:40:21 +1000 From: Anton Blanchard To: Jan-Bernd Themann Subject: Re: [PATCH 4/6] ehea: header files Message-ID: <20060811214020.GG479@krispykreme> References: <44D99F56.7010201@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <44D99F56.7010201@de.ibm.com> Cc: Thomas Klein , netdev , linux-kernel , linux-ppc , Christoph Raisch , Marcus Eder List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi, > drivers/net/ehea/ehea.h | 452 > +#define EHEA_DRIVER_NAME "IBM eHEA" You are using this for ethtool get_drvinfo. Im not sure if it should match the module name, and I worry about having a space in the name. Any ideas on what we should be doing here? > +#define NET_IP_ALIGN 0 Shouldnt override this in your driver. > +#define EDEB_P_GENERIC(level, idstring, format, args...) \ > +#define EDEB_P_GENERIC(level,idstring,format,args...) \ > +#define EDEB(level, format, args...) \ > +#define EDEB_ERR(level, format, args...) \ > +#define EDEB_EN(level, format, args...) \ > +#define EDEB_EX(level, format, args...) \ > +#define EDEB_DMP(level, adr, len, format, args...) \ There are a lot of debug statements in the driver. When doing a review I stripped them all out to make it easier to read. As suggested by others, using the standard debug macros (where still required) would be a good idea. Anton