From: David Miller <davem@davemloft.net>
To: linas@austin.ibm.com
Cc: akpm@osdl.org, arnd@arndb.de, netdev@vger.kernel.org,
jklewis@us.ibm.com, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, Jens.Osterkamp@de.ibm.com,
jgarzik@pobox.com, shemminger@osdl.org
Subject: Re: [RFC] HOWTO use NAPI to reduce TX interrupts
Date: Mon, 21 Aug 2006 16:56:16 -0700 (PDT) [thread overview]
Message-ID: <20060821.165616.107936004.davem@davemloft.net> (raw)
In-Reply-To: <20060821235244.GJ5427@austin.ibm.com>
From: linas@austin.ibm.com (Linas Vepstas)
Date: Mon, 21 Aug 2006 18:52:44 -0500
> Under what circumstance does one turn TX interrupts back on?
> I couldn't quite figure that out.
Don't touch interrupts until both RX and TX queue work is
fullydepleted. You seem to have this notion that RX and TX interrupts
are seperate. They aren't, even if your device can generate those
events individually. Whatever interrupt you get, you shut down all
interrupt sources and schedule the ->poll(). Then ->poll() does
something like:
all_tx_completion_work();
ret = as_much_rx_work_as_budget_and_quota_allows();
if (!ret)
reenable_interrupts_and_complet_napi_poll();
You always run the TX completion work fully, then you do the RX work
within the quota/budget.
See the tg3 driver for details, really...
next prev parent reply other threads:[~2006-08-21 23:56 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-18 22:07 [PATCH 0/6]: powerpc/cell spidernet ethernet driver update Linas Vepstas
2006-08-18 22:20 ` [PATCH 1/6]: powerpc/cell spidernet burst alignment patch Linas Vepstas
2006-08-18 22:51 ` Arnd Bergmann
2006-08-18 22:21 ` [PATCH 2/6]: powerpc/cell spidernet low watermark patch Linas Vepstas
2006-08-18 23:09 ` Arnd Bergmann
2006-08-20 6:31 ` Benjamin Herrenschmidt
2006-08-20 10:03 ` Arnd Bergmann
2006-08-23 21:36 ` Linas Vepstas
2006-08-23 22:03 ` David Miller
2006-08-18 22:23 ` [PATCH 3/6]: powerpc/cell spidernet stop error printing patch Linas Vepstas
2006-08-18 22:25 ` [PATCH 4/6]: powerpc/cell spidernet ethtool -i version number info Linas Vepstas
2006-08-18 22:56 ` Arnd Bergmann
2006-08-18 22:26 ` [PATCH 5/6]: powerpc/cell spidernet bottom half Linas Vepstas
2006-08-18 23:03 ` Arnd Bergmann
2006-08-19 0:56 ` [RFC] HOWTO use NAPI to reduce TX interrupts Arnd Bergmann
2006-08-20 1:31 ` Stephen Hemminger
2006-08-19 11:25 ` Arnd Bergmann
2006-08-20 17:48 ` [RFC v2] " Arnd Bergmann
2006-08-21 20:40 ` NAPI documentation Stephen Hemminger
2006-08-21 22:05 ` David Miller
2006-08-21 22:09 ` Stephen Hemminger
2006-08-21 22:17 ` David Miller
2006-08-21 23:52 ` [RFC] HOWTO use NAPI to reduce TX interrupts Linas Vepstas
2006-08-21 23:56 ` David Miller [this message]
2006-08-22 0:29 ` Roland Dreier
2006-08-22 0:32 ` David Miller
2006-08-23 1:29 ` Shirley Ma
2006-08-23 21:52 ` [PATCH 5/6]: powerpc/cell spidernet bottom half Linas Vepstas
2006-08-18 22:29 ` [PATCH 6/6]: powerpc/cell spidernet refine locking Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060821.165616.107936004.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Jens.Osterkamp@de.ibm.com \
--cc=akpm@osdl.org \
--cc=arnd@arndb.de \
--cc=jgarzik@pobox.com \
--cc=jklewis@us.ibm.com \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).