From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tinc.cathedrallabs.org (tinc.cathedrallabs.org [72.9.252.66]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTP id D3FB267BA4 for ; Thu, 21 Sep 2006 04:14:18 +1000 (EST) Date: Wed, 20 Sep 2006 14:54:34 -0300 From: Aristeu Sergio Rozanski Filho To: Brad Boyer Subject: Re: [PATCH] adbhid: make KEY_SYSRQ configurable on ADB based machines Message-ID: <20060920175434.GE6854@cathedrallabs.org> References: <20060808154937.GC3363@cathedrallabs.org> <20060920134459.GC23803@cathedrallabs.org> <20060920053656.GA28326@cynthia.pants.nu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20060920053656.GA28326@cynthia.pants.nu> Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , > On Wed, Sep 20, 2006 at 10:44:59AM -0300, Aristeu Sergio Rozanski Filho wrote: > > > This patch adds a sysfs entry on /sys/class/adb/keyboard0/sysrq_key to > > > configure which key will be mapped to KEY_SYSRQ. This is needed to make > > > sysrq usable on machines which doesn't have current sysrq key. This > > > patch and the previous two ones has been tested for some days in my > > > machine without problems. > > any comments on this one? > > The only thing I see is that each ADB keyboard device will have an entry > in sysfs to change the sysrq key, but they will all set the same global. > It's a little misleading, but I don't think it's a major issue. And > before anyone asks, I have in fact had multiple ADB keyboards attached > to a single machine. It was useful for multi-player games. yup, I was expecting someone to show up and say it's possible :) I'll fix this up, thanks Brad -- Aristeu