From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: linas@austin.ibm.com (Linas Vepstas)
Cc: linuxppc-dev@ozlabs.org, linux-pci@atrey.karlin.mff.cuni.cz,
Luca <kronos.it@gmail.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH]: PCI Error Recovery: Symbios SCSI device driver
Date: Fri, 22 Sep 2006 16:39:29 -0700 [thread overview]
Message-ID: <20060922163929.bb870ee1.rdunlap@xenotime.net> (raw)
In-Reply-To: <20060922233235.GB14213@austin.ibm.com>
On Fri, 22 Sep 2006 18:32:35 -0500 Linas Vepstas wrote:
> On Sat, Sep 23, 2006 at 12:06:29AM +0200, Luca wrote:
> >
> > Space after function name? You put in other places too, it's not
> > consistent with the rest of the patch.
>
> Oops. I was also coding on a different project recently, with a
> different style. I'll send a revised patch in a moment.
Please change if()'s to use
if (var == constant)
instead of
if (constant == var)
also. (or whatever condition is being used) Thanks.
> > > + if (pci_enable_device(pdev))
> > > + printk (KERN_ERR "%s: device setup failed most egregiously\n",
> > > + sym_name(np));
> >
> > Is the failure of pci_enable_device ignored on purpose?
>
> No. :-( Thanks for the catch. I think I got cross-eyed staring at the code.
---
~Randy
next prev parent reply other threads:[~2006-09-22 23:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-21 23:13 [PATCH]: PCI Error Recovery: Symbios SCSI device driver Linas Vepstas
2006-09-22 22:06 ` Luca
2006-09-22 23:32 ` Linas Vepstas
2006-09-22 23:39 ` Randy.Dunlap [this message]
2006-09-22 23:50 ` Linas Vepstas
2006-09-23 0:57 ` Randy.Dunlap
2006-09-22 23:55 ` [PATCH]: (revised 2) " Linas Vepstas
2006-09-22 23:43 ` [PATCH]: (revised) " Linas Vepstas
-- strict thread matches above, loose matches on Subject: below --
2007-07-02 18:39 [PATCH]: " Linas Vepstas
2007-07-05 18:28 ` Andrew Morton
2007-07-05 18:54 ` Matthew Wilcox
2007-08-02 22:53 ` Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060922163929.bb870ee1.rdunlap@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=kronos.it@gmail.com \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).