From: Olof Johansson <olof@lixom.net>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: ppc-dev <linuxppc-dev@ozlabs.org>, paulus@samba.org
Subject: Re: [PATCH 2/7] [POWERPC] The two vio HVC backends clash
Date: Tue, 26 Sep 2006 00:10:41 -0500 [thread overview]
Message-ID: <20060926001041.4c708613@pb15> (raw)
In-Reply-To: <20060926133548.43afd711.sfr@canb.auug.org.au>
On Tue, 26 Sep 2006 13:35:48 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> diff --git a/drivers/char/hvc_iseries.c b/drivers/char/hvc_iseries.c
> index 4747729..ea36201 100644
> --- a/drivers/char/hvc_iseries.c
> +++ b/drivers/char/hvc_iseries.c
> @@ -29,6 +29,7 @@ #include <linux/console.h>
> #include <asm/hvconsole.h>
> #include <asm/vio.h>
> #include <asm/prom.h>
> +#include <asm/firmware.h>
> #include <asm/iseries/vio.h>
> #include <asm/iseries/hv_call.h>
> #include <asm/iseries/hv_lp_config.h>
> @@ -493,6 +494,9 @@ static int hvc_vio_init(void)
> atomic_t wait_flag;
> int rc;
>
> + if (!firmware_has_feature(FW_FEATURE_ISERIES))
> + return -EIO;
> +
Shouldn't this be -ENODEV?
-Olof
prev parent reply other threads:[~2006-09-26 5:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-26 3:34 [PATCH 1/7] [POWERPC] iSeries: set FW_FEATURE_ISERIES earlier Stephen Rothwell
2006-09-26 3:35 ` [PATCH 2/7] [POWERPC] The two vio HVC backends clash Stephen Rothwell
2006-09-26 3:36 ` [PATCH 3/7] [POWERPC] modify PCI code for a merged kernel Stephen Rothwell
2006-09-26 3:37 ` [PATCH 4/7] [POWERPC] fix ioremap for a combined kernel Stephen Rothwell
2006-09-26 3:39 ` [PATCH 5/7] [POWERPC] Allow combined iSeries and MULTIPLATFORM build Stephen Rothwell
2006-09-26 3:40 ` [PATCH 6/7] [POWERPC] iSeries does not need pcibios_fixup_resources Stephen Rothwell
2006-09-26 3:42 ` [PATCH 7/7] [POWERPC] implement BEGIN/END_FW_FTR_SECTION Stephen Rothwell
2006-10-04 7:58 ` Benjamin Herrenschmidt
2006-10-04 8:26 ` Stephen Rothwell
2006-10-04 10:08 ` Benjamin Herrenschmidt
2006-10-02 10:25 ` [PATCH 5/7] [POWERPC] Allow combined iSeries and MULTIPLATFORM build Paul Mackerras
2006-10-04 4:58 ` Stephen Rothwell
2006-10-04 8:02 ` [PATCH 3/7] [POWERPC] modify PCI code for a merged kernel Benjamin Herrenschmidt
2006-09-26 5:10 ` Olof Johansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060926001041.4c708613@pb15 \
--to=olof@lixom.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).