From: Andrew Morton <akpm@osdl.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Adrian Bunk <bunk@stusta.de>,
linuxppc-dev@ozlabs.org, Judith Lebzelter <judith@osdl.org>,
Kernel list <linux-kernel@vger.kernel.org>,
Linux
Subject: Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386
Date: Mon, 2 Oct 2006 21:55:27 -0700 [thread overview]
Message-ID: <20061002215527.096a8762.akpm@osdl.org> (raw)
In-Reply-To: <1159850979.5482.40.camel@localhost.localdomain>
On Tue, 03 Oct 2006 14:49:39 +1000
Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> On Mon, 2006-10-02 at 21:44 -0700, Andrew Morton wrote:
> > On Tue, 03 Oct 2006 14:37:25 +1000
> > Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
> >
> > > > > You might want to convince Andrew accepting my patch to make
> > > > > virt_to_bus/bus_to_virt give compile warnings on i386 for making
> > > > > people more aware of this problem...
> > > > >...
> > >
> > > Andrew, is there any reason not to take that patch ?
> >
> > It generates lots of warnings from drivers which nobody does any work on.
> >
> > Net result: lots of new warnings, no fixed bugs.
>
> Are you sure the warnings won't cause somebody like Al to go through
> them all and fix them ?
The drivers simply don't link on some architectures, due to missing
virt_to_bus/bus_to_virt. They aren't hard to find.
> At least they should be marked either CONFIG_BROKEN or X86 only (or
> whatever arch they are supposed to be used on).
>
Something like that would make sense. I guess a new config option.
next prev parent reply other threads:[~2006-10-03 4:55 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-02 21:49 Undefined '.bus_to_virt', '.virt_to_bus' causes compile error on Powerpc 64-bit Judith Lebzelter
2006-10-02 23:44 ` Adrian Bunk
2006-10-03 1:22 ` [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386 Adrian Bunk
2006-10-03 1:48 ` Nicholas Miell
2006-10-03 1:58 ` Adrian Bunk
2006-10-03 2:55 ` Nicholas Miell
2006-10-03 4:37 ` Benjamin Herrenschmidt
2006-10-03 11:29 ` Alan Cox
2006-10-03 4:37 ` Benjamin Herrenschmidt
2006-10-03 4:44 ` Andrew Morton
2006-10-03 4:49 ` Benjamin Herrenschmidt
2006-10-03 4:55 ` Andrew Morton [this message]
2006-10-03 5:07 ` Adrian Bunk
2006-10-03 9:36 ` Stefan Richter
2006-10-03 11:24 ` Alan Cox
2006-10-03 20:58 ` Undefined '.bus_to_virt', '.virt_to_bus' causes compile error on Powerpc 64-bit Guennadi Liakhovetski
2006-10-03 1:05 ` Benjamin Herrenschmidt
2006-10-03 11:23 ` Alan Cox
2006-10-03 1:16 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061002215527.096a8762.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=bunk@stusta.de \
--cc=judith@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).