From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.osdl.org (smtp.osdl.org [65.172.181.4]) (using TLSv1 with cipher EDH-RSA-DES-CBC3-SHA (168/168 bits)) (Client CN "smtp.osdl.org", Issuer "OSDL Hostmaster" (not verified)) by ozlabs.org (Postfix) with ESMTP id 81D9367C01 for ; Tue, 3 Oct 2006 14:55:34 +1000 (EST) Date: Mon, 2 Oct 2006 21:55:27 -0700 From: Andrew Morton To: Benjamin Herrenschmidt Subject: Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386 Message-Id: <20061002215527.096a8762.akpm@osdl.org> In-Reply-To: <1159850979.5482.40.camel@localhost.localdomain> References: <20061002214954.GD665@shell0.pdx.osdl.net> <20061002234428.GE3278@stusta.de> <20061003012241.GF3278@stusta.de> <1159850245.5482.32.camel@localhost.localdomain> <20061002214400.0a83b743.akpm@osdl.org> <1159850979.5482.40.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: Adrian Bunk , linuxppc-dev@ozlabs.org, Judith Lebzelter , Kernel list , Linux List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 03 Oct 2006 14:49:39 +1000 Benjamin Herrenschmidt wrote: > On Mon, 2006-10-02 at 21:44 -0700, Andrew Morton wrote: > > On Tue, 03 Oct 2006 14:37:25 +1000 > > Benjamin Herrenschmidt wrote: > > > > > > > You might want to convince Andrew accepting my patch to make > > > > > virt_to_bus/bus_to_virt give compile warnings on i386 for making > > > > > people more aware of this problem... > > > > >... > > > > > > Andrew, is there any reason not to take that patch ? > > > > It generates lots of warnings from drivers which nobody does any work on. > > > > Net result: lots of new warnings, no fixed bugs. > > Are you sure the warnings won't cause somebody like Al to go through > them all and fix them ? The drivers simply don't link on some architectures, due to missing virt_to_bus/bus_to_virt. They aren't hard to find. > At least they should be marked either CONFIG_BROKEN or X86 only (or > whatever arch they are supposed to be used on). > Something like that would make sense. I guess a new config option.