[PATCH] mv643xx_eth_pcidev : implement hotplug by matching the Discovery II/III northbridge pci id (Was: + mv643xx_eth_pcidev-implements-hotplug-for-the-marvell-gige-functionality-by-probing-the-northbridge-pci-id.patch added to -mm tree)

[PATCH] mv643xx_eth_pcidev : implement hotplug by matching the Discovery II/III northbridge pci id (Was: + mv643xx_eth_pcidev-implements-hotplug-for-the-marvell-gige-functionality-by-probing-the-northbridge-pci-id.patch added to -mm tree)

[Sven Luther]

From: Sven Luther <sl@bplan-gmbh.de>

Match the Marvell Discovery II/III northbridge pci id to add hotplug
support for the builtin gigabit ethernet driver (mv643xx_eth).

Signed-off-by: Sven Luther <sl@bplan-gmbh.de>

---

On Tue, Sep 19, 2006 at 09:34:10AM -0700, Andrew Morton wrote:
> On Tue, 19 Sep 2006 17:16:11 +0200
> Sven Luther <sven.luther@wanadoo.fr> wrote:
> 
> > I was wondering if you still had this patch in your tree, and what its status
> > for upstream inclusion where ? 
> 
> It's in Jeff's net driver tree and I assume he plans on merging it into 2.6.19.

Since i couldn't find any trace of this patch either in the -mm tree or the
-netdev one, i am now resubmitting a cleaned up version of this patch.

The patch was originally submitted on october 25 2005, and signed off by :

Signed-off-by: Nicolas DET <det.nicolas@free.fr>
Signed-off-by: Sven Luther <sl@bplan-gmbh.de>
Cc: Jeff Garzik <jgarzik@pobox.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>

Altough the proper solution to this issue would be to add hotplug support to
the plateform devices through the OF device tree, no support for this has been
added since last year, and with most major distribution having switched to
using udev or something similar, it is important to have a solution for
autoloading this driver. This patch has been in activity in the debian
distribution since last year, and it is possible other distributions use it as
well.

So, i wonder if it would be possible to still add it to 2.6.19, even though
the official schedule is closed, or if not, to add it for 2.6.20 ? 

Friendly,

Sven Luther

--- linux/drivers/net/mv643xx_eth.c.orig	2006-10-03 14:21:33.000000000 +0200
+++ linux/drivers/net/mv643xx_eth.c	2006-10-03 14:23:54.000000000 +0200
@@ -43,6 +43,8 @@
 #include <linux/ethtool.h>
 #include <linux/platform_device.h>
 
+#include <linux/pci.h>
+
 #include <asm/io.h>
 #include <asm/types.h>
 #include <asm/pgtable.h>
@@ -1563,6 +1565,15 @@
 		" and Dale Farnsworth");
 MODULE_DESCRIPTION("Ethernet driver for Marvell MV643XX");
 
+static struct pci_device_id pci_marvell_mv64360[] = {
+	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, PCI_DEVICE_ID_MARVELL_MV64360) },
+	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, PCI_DEVICE_ID_MARVELL_MV64460) },
+	{ }
+};
+
+MODULE_DEVICE_TABLE(pci, pci_marvell_mv64360);
+
+
 /*
  * The second part is the low level driver of the gigE ethernet ports.
  */

Re: [PATCH] mv643xx_eth_pcidev : implement hotplug by matching the Discovery II/III northbridge pci id (Was: + mv643xx_eth_pcidev-implements-hotplug-for-the-marvell-gige-functionality-by-probing-the-northbridge-pci-id.patch added to -mm tree)

[Olaf Hering]

On Tue, Oct 03, Sven Luther wrote:

> Match the Marvell Discovery II/III northbridge pci id to add hotplug
> support for the builtin gigabit ethernet driver (mv643xx_eth).

there is no need for this patch. a0245f7ad5214cb00131d7cd176446e067c913dc fixed it.
Put this in your early boot scripts:

for i in `find /sys -name modalias`;do /sbin/modprobe -v "`cat $i`"&done

Re: [PATCH] mv643xx_eth_pcidev : implement hotplug by matching the Discovery II/III northbridge pci id (Was: + mv643xx_eth_pcidev-implements-hotplug-for-the-marvell-gige-functionality-by-probing-the-northbridge-pci-id.patch added to -mm tree)

[Sven Luther]

On Tue, Oct 03, 2006 at 04:23:55PM +0200, Olaf Hering wrote:
> On Tue, Oct 03, Sven Luther wrote:
> 
> > Match the Marvell Discovery II/III northbridge pci id to add hotplug
> > support for the builtin gigabit ethernet driver (mv643xx_eth).
> 
> there is no need for this patch. a0245f7ad5214cb00131d7cd176446e067c913dc fixed it.

I think that is a limited description, not sure.

> Put this in your early boot scripts:
> 
> for i in `find /sys -name modalias`;do /sbin/modprobe -v "`cat $i`"&done

Does this also account for all those distributions out there who have pure
udev based installers ? 

Friendly,

Sven Luther

Re: [PATCH] mv643xx_eth_pcidev : implement hotplug by matching the Discovery II/III northbridge pci id (Was: + mv643xx_eth_pcidev-implements-hotplug-for-the-marvell-gige-functionality-by-probing-the-northbridge-pci-id.patch added to -mm tree)

[Olaf Hering]

On Tue, Oct 03, Sven Luther wrote:

> Does this also account for all those distributions out there who have pure
> udev based installers ? 

Maybe udev does just a 'modprobe $MODALIAS', I dont know.

Re: [PATCH] mv643xx_eth_pcidev : implement hotplug by matching the Discovery II/III northbridge pci id (Was: + mv643xx_eth_pcidev-implements-hotplug-for-the-marvell-gige-functionality-by-probing-the-northbridge-pci-id.patch added to -mm tree)

[Sven Luther]

On Tue, Oct 03, 2006 at 06:46:05PM +0200, Olaf Hering wrote:
> On Tue, Oct 03, Sven Luther wrote:
> 
> > Does this also account for all those distributions out there who have pure
> > udev based installers ? 
> 
> Maybe udev does just a 'modprobe $MODALIAS', I dont know.

Do you have a more complete url to the patch ? Just googling for the checksum
didn't bring anything.

I will investigate the udev side of this.

Friendly,

Sven Luther

Re: [PATCH] mv643xx_eth_pcidev : implement hotplug by matching the Discovery II/III northbridge pci id (Was: + mv643xx_eth_pcidev-implements-hotplug-for-the-marvell-gige-functionality-by-probing-the-northbridge-pci-id.patch added to -mm tree)

[Olaf Hering]

On Tue, Oct 03, Sven Luther wrote:

> Do you have a more complete url to the patch ? Just googling for the checksum
> didn't bring anything.

http://www.kernel.org/git 
-> linux/kernel/git/torvalds/linux-2.6.git
-> shortlog
enter a0245f7ad5214cb00131d7cd176446e067c913dc into the search field
http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=a0245f7ad5214cb00131d7cd176446e067c913dc

Re: [PATCH] mv643xx_eth_pcidev : implement hotplug by matching the Discovery II/III northbridge pci id (Was: + mv643xx_eth_pcidev-implements-hotplug-for-the-marvell-gige-functionality-by-probing-the-northbridge-pci-id.patch added to -mm tree)

[Brent Cook]

On Tuesday 03 October 2006 12:09, Sven Luther wrote:
> On Tue, Oct 03, 2006 at 06:46:05PM +0200, Olaf Hering wrote:
> > On Tue, Oct 03, Sven Luther wrote:
> > > Does this also account for all those distributions out there who have
> > > pure udev based installers ?
> >
> > Maybe udev does just a 'modprobe $MODALIAS', I dont know.
>
> Do you have a more complete url to the patch ? Just googling for the
> checksum didn't bring anything.

Is this it? I just pasted the md5 sum into the search box:

http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=a0245f7ad5214cb00131d7cd176446e067c913dc

> I will investigate the udev side of this.
>
> Friendly,
>
> Sven Luther
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev