From: Kim Phillips <kim.phillips@freescale.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH 4/7] Add MPC8360EMDS board support
Date: Tue, 3 Oct 2006 13:02:45 -0500 [thread overview]
Message-ID: <20061003130245.58267c54.kim.phillips@freescale.com> (raw)
In-Reply-To: <41AC40EF-31AC-42FE-9C1A-9B80233D2E64@kernel.crashing.org>
On Mon, 2 Oct 2006 22:19:14 -0500
Kumar Gala <galak@kernel.crashing.org> wrote:
> [snip]
>
> > +static u8 *bcsr_regs = NULL;
> > +
> > +u8 *get_bcsr(void)
> > +{
> > + return bcsr_regs;
> > +}
>
> Is get_bcsr() needed since you removed its use from ucc_geth? (if
> not, let's remove it and the header as well).
>
it will be once we figure out a better way of handling it from usb and ethernet phy code. I had just removed it due to Paul's comment (bcsr bits are being manipulated in the wrong place (ucc_geth)).
Kim
next prev parent reply other threads:[~2006-10-03 18:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-03 1:09 [PATCH 4/7] Add MPC8360EMDS board support Kim Phillips
2006-10-03 3:19 ` Kumar Gala
2006-10-03 18:02 ` Kim Phillips [this message]
2006-10-03 18:20 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061003130245.58267c54.kim.phillips@freescale.com \
--to=kim.phillips@freescale.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).