Re: [PATCH 4/7] Add MPC8360EMDS board support (try 2)

[Kim Phillips <kim.phillips@freescale.com>]

On Tue, 3 Oct 2006 23:27:42 -0500
Kumar Gala <galak@kernel.crashing.org> wrote:

> 
> On Oct 3, 2006, at 11:17 PM, Kim Phillips wrote:
> 
<snip>
> >  arch/powerpc/platforms/83xx/mpc8360e_pb.c  |  220 ++++++
> >  arch/powerpc/platforms/83xx/mpc8360e_pb.h  |   23 +
> >  3 files changed, 1261 insertions(+), 0 deletions(-)
> 
> What's the point of the mpc8360e_pb.h if there's nothing in it?
> 
well I thought I was being consistent with the other 83xx boards ;)

> Also, any reason the files are _pb and config is emds?
> 
_pb == processor board, the core of the mds (modular development system).  The pb can be operated independently of the rest of what comprises the mds.

I used mds nomenclature in 832x since the support includes parts of the mds that are separate from just the pb, e.g. the pci bits in the device tree.

but we need to be more consistent, I agree.

also, there is a wealth of duplicated platform code among each of the four 83xx platforms.  Somethings wrong when one duplicates a file just to s/836/832/g.  How about consolidating them all down to one mpc83xx_mach.c file that enables potential board quirks based on the dev tree root's model property?  That will eliminate all the redundant code, and get rid of the file naming inconsistencies.

Kim