From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout.stusta.mhn.de (mailout.stusta.mhn.de [141.84.69.5]) by ozlabs.org (Postfix) with SMTP id 5C58F67B22 for ; Tue, 10 Oct 2006 14:55:37 +1000 (EST) Date: Tue, 10 Oct 2006 06:55:34 +0200 From: Adrian Bunk To: Randy Dunlap Subject: Re: [PATCH] Add Kconfig dependency !VT for VIOCONS Message-ID: <20061010045534.GA3650@stusta.de> References: <20061006180549.GB3684@shell0.pdx.osdl.net> <20061006200007.GD3684@shell0.pdx.osdl.net> <20061006143437.f7338860.rdunlap@xenotime.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20061006143437.f7338860.rdunlap@xenotime.net> Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Oct 06, 2006 at 02:34:37PM -0700, Randy Dunlap wrote: > On Fri, 6 Oct 2006 13:00:07 -0700 Judith Lebzelter wrote: > > > Actually, this gets rid of the CONFIG_VIOCONS from my .config, but > > then I get another warning when I build: > > > > Warning! Found recursive dependency: VT VIOCONS VT > > > > Can anyone suggest something? > > I think that your patch is mostly good/correct, but one more line > is needed on the VT side: a deletion. > > This works for me: > > From: Randy Dunlap > > Make allmodconfig .config build successfully by making VIOCONS > available only if VT=n. VT need not check VIOCONS. > > Signed-off-by: Randy Dunlap > --- > arch/powerpc/platforms/iseries/Kconfig | 2 +- > drivers/char/Kconfig | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > > --- linux-2619-rc1g2.orig/arch/powerpc/platforms/iseries/Kconfig > +++ linux-2619-rc1g2/arch/powerpc/platforms/iseries/Kconfig > @@ -3,7 +3,7 @@ menu "iSeries device drivers" > depends on PPC_ISERIES > > config VIOCONS > - tristate "iSeries Virtual Console Support (Obsolete)" > + tristate "iSeries Virtual Console Support (Obsolete)" if !VT > help >... > config VT > bool "Virtual terminal" if EMBEDDED With this dependency on EMBEDDED, you could as well simply remove VIOCONS... > select INPUT > - default y if !VIOCONS Removing the "default y" is wrong. > ---help--- > If you say Y here, you will get support for terminal devices with > display and keyboard devices. These are called "virtual" because you >... > ~Randy cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed