* [PATCH] Add Kconfig dependency !VT for VIOCONS
@ 2006-10-06 18:05 Judith Lebzelter
2006-10-06 20:00 ` Judith Lebzelter
0 siblings, 1 reply; 9+ messages in thread
From: Judith Lebzelter @ 2006-10-06 18:05 UTC (permalink / raw)
To: linuxppc-dev; +Cc: linux-kernel
From: Judith Lebzelter <judith@osdl.org>
Add Kconfig dependency !VT for VIOCONS
I would like to avoid this compile error in 'allmodconfig':
drivers/char/viocons.c:52:2: error: #error You must turn off CONFIG_VT to use CONFIG_VIOCONS
Signed-off-by: Judith Lebzelter <judith@osdl.org>
---
Index: linux/arch/powerpc/platforms/iseries/Kconfig
===================================================================
--- linux.orig/arch/powerpc/platforms/iseries/Kconfig 2006-10-05 09:35:09.000000000 -0700
+++ linux/arch/powerpc/platforms/iseries/Kconfig 2006-10-06 10:30:19.333425703 -0700
@@ -4,6 +4,7 @@
config VIOCONS
tristate "iSeries Virtual Console Support (Obsolete)"
+ depends on !VT
help
This is the old virtual console driver for legacy iSeries.
You should use the iSeries Hypervisor Virtual Console
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Add Kconfig dependency !VT for VIOCONS
2006-10-06 18:05 [PATCH] Add Kconfig dependency !VT for VIOCONS Judith Lebzelter
@ 2006-10-06 20:00 ` Judith Lebzelter
2006-10-06 21:34 ` Randy Dunlap
0 siblings, 1 reply; 9+ messages in thread
From: Judith Lebzelter @ 2006-10-06 20:00 UTC (permalink / raw)
To: Judith Lebzelter; +Cc: linuxppc-dev, linux-kernel
Actually, this gets rid of the CONFIG_VIOCONS from my .config, but
then I get another warning when I build:
Warning! Found recursive dependency: VT VIOCONS VT
Can anyone suggest something?
Thanks,
Judith
On Fri, Oct 06, 2006 at 11:05:49AM -0700, Judith Lebzelter wrote:
> From: Judith Lebzelter <judith@osdl.org>
>
> Add Kconfig dependency !VT for VIOCONS
>
> I would like to avoid this compile error in 'allmodconfig':
> drivers/char/viocons.c:52:2: error: #error You must turn off CONFIG_VT to use CONFIG_VIOCONS
>
> Signed-off-by: Judith Lebzelter <judith@osdl.org>
> ---
>
> Index: linux/arch/powerpc/platforms/iseries/Kconfig
> ===================================================================
> --- linux.orig/arch/powerpc/platforms/iseries/Kconfig 2006-10-05 09:35:09.000000000 -0700
> +++ linux/arch/powerpc/platforms/iseries/Kconfig 2006-10-06 10:30:19.333425703 -0700
> @@ -4,6 +4,7 @@
>
> config VIOCONS
> tristate "iSeries Virtual Console Support (Obsolete)"
> + depends on !VT
> help
> This is the old virtual console driver for legacy iSeries.
> You should use the iSeries Hypervisor Virtual Console
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Add Kconfig dependency !VT for VIOCONS
2006-10-06 20:00 ` Judith Lebzelter
@ 2006-10-06 21:34 ` Randy Dunlap
2006-10-10 4:55 ` Adrian Bunk
0 siblings, 1 reply; 9+ messages in thread
From: Randy Dunlap @ 2006-10-06 21:34 UTC (permalink / raw)
To: Judith Lebzelter; +Cc: linuxppc-dev, linux-kernel
On Fri, 6 Oct 2006 13:00:07 -0700 Judith Lebzelter wrote:
> Actually, this gets rid of the CONFIG_VIOCONS from my .config, but
> then I get another warning when I build:
>
> Warning! Found recursive dependency: VT VIOCONS VT
>
> Can anyone suggest something?
I think that your patch is mostly good/correct, but one more line
is needed on the VT side: a deletion.
This works for me:
From: Randy Dunlap <rdunlap@xenotime.net>
Make allmodconfig .config build successfully by making VIOCONS
available only if VT=n. VT need not check VIOCONS.
Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
---
arch/powerpc/platforms/iseries/Kconfig | 2 +-
drivers/char/Kconfig | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
--- linux-2619-rc1g2.orig/arch/powerpc/platforms/iseries/Kconfig
+++ linux-2619-rc1g2/arch/powerpc/platforms/iseries/Kconfig
@@ -3,7 +3,7 @@ menu "iSeries device drivers"
depends on PPC_ISERIES
config VIOCONS
- tristate "iSeries Virtual Console Support (Obsolete)"
+ tristate "iSeries Virtual Console Support (Obsolete)" if !VT
help
This is the old virtual console driver for legacy iSeries.
You should use the iSeries Hypervisor Virtual Console
--- linux-2619-rc1g2.orig/drivers/char/Kconfig
+++ linux-2619-rc1g2/drivers/char/Kconfig
@@ -7,7 +7,6 @@ menu "Character devices"
config VT
bool "Virtual terminal" if EMBEDDED
select INPUT
- default y if !VIOCONS
---help---
If you say Y here, you will get support for terminal devices with
display and keyboard devices. These are called "virtual" because you
> Thanks,
> Judith
>
> On Fri, Oct 06, 2006 at 11:05:49AM -0700, Judith Lebzelter wrote:
> > From: Judith Lebzelter <judith@osdl.org>
> >
> > Add Kconfig dependency !VT for VIOCONS
> >
> > I would like to avoid this compile error in 'allmodconfig':
> > drivers/char/viocons.c:52:2: error: #error You must turn off CONFIG_VT to use CONFIG_VIOCONS
> >
> > Signed-off-by: Judith Lebzelter <judith@osdl.org>
> > ---
> >
> > Index: linux/arch/powerpc/platforms/iseries/Kconfig
> > ===================================================================
> > --- linux.orig/arch/powerpc/platforms/iseries/Kconfig 2006-10-05 09:35:09.000000000 -0700
> > +++ linux/arch/powerpc/platforms/iseries/Kconfig 2006-10-06 10:30:19.333425703 -0700
> > @@ -4,6 +4,7 @@
> >
> > config VIOCONS
> > tristate "iSeries Virtual Console Support (Obsolete)"
> > + depends on !VT
> > help
> > This is the old virtual console driver for legacy iSeries.
> > You should use the iSeries Hypervisor Virtual Console
---
~Randy
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Add Kconfig dependency !VT for VIOCONS
2006-10-06 21:34 ` Randy Dunlap
@ 2006-10-10 4:55 ` Adrian Bunk
2006-10-10 16:10 ` Randy Dunlap
0 siblings, 1 reply; 9+ messages in thread
From: Adrian Bunk @ 2006-10-10 4:55 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linuxppc-dev, linux-kernel
On Fri, Oct 06, 2006 at 02:34:37PM -0700, Randy Dunlap wrote:
> On Fri, 6 Oct 2006 13:00:07 -0700 Judith Lebzelter wrote:
>
> > Actually, this gets rid of the CONFIG_VIOCONS from my .config, but
> > then I get another warning when I build:
> >
> > Warning! Found recursive dependency: VT VIOCONS VT
> >
> > Can anyone suggest something?
>
> I think that your patch is mostly good/correct, but one more line
> is needed on the VT side: a deletion.
>
> This works for me:
>
> From: Randy Dunlap <rdunlap@xenotime.net>
>
> Make allmodconfig .config build successfully by making VIOCONS
> available only if VT=n. VT need not check VIOCONS.
>
> Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> ---
> arch/powerpc/platforms/iseries/Kconfig | 2 +-
> drivers/char/Kconfig | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> --- linux-2619-rc1g2.orig/arch/powerpc/platforms/iseries/Kconfig
> +++ linux-2619-rc1g2/arch/powerpc/platforms/iseries/Kconfig
> @@ -3,7 +3,7 @@ menu "iSeries device drivers"
> depends on PPC_ISERIES
>
> config VIOCONS
> - tristate "iSeries Virtual Console Support (Obsolete)"
> + tristate "iSeries Virtual Console Support (Obsolete)" if !VT
> help
>...
> config VT
> bool "Virtual terminal" if EMBEDDED
With this dependency on EMBEDDED, you could as well simply remove
VIOCONS...
> select INPUT
> - default y if !VIOCONS
Removing the "default y" is wrong.
> ---help---
> If you say Y here, you will get support for terminal devices with
> display and keyboard devices. These are called "virtual" because you
>...
> ~Randy
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Add Kconfig dependency !VT for VIOCONS
2006-10-10 4:55 ` Adrian Bunk
@ 2006-10-10 16:10 ` Randy Dunlap
2006-10-11 3:56 ` Adrian Bunk
0 siblings, 1 reply; 9+ messages in thread
From: Randy Dunlap @ 2006-10-10 16:10 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linuxppc-dev, linux-kernel
On Tue, 10 Oct 2006 06:55:34 +0200 Adrian Bunk wrote:
> On Fri, Oct 06, 2006 at 02:34:37PM -0700, Randy Dunlap wrote:
> > On Fri, 6 Oct 2006 13:00:07 -0700 Judith Lebzelter wrote:
> >
> > > Actually, this gets rid of the CONFIG_VIOCONS from my .config, but
> > > then I get another warning when I build:
> > >
> > > Warning! Found recursive dependency: VT VIOCONS VT
> > >
> > > Can anyone suggest something?
> >
> > I think that your patch is mostly good/correct, but one more line
> > is needed on the VT side: a deletion.
> >
> > This works for me:
> >
> > From: Randy Dunlap <rdunlap@xenotime.net>
> >
> > Make allmodconfig .config build successfully by making VIOCONS
> > available only if VT=n. VT need not check VIOCONS.
> >
> > Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> > ---
> > arch/powerpc/platforms/iseries/Kconfig | 2 +-
> > drivers/char/Kconfig | 1 -
> > 2 files changed, 1 insertion(+), 2 deletions(-)
> >
> > --- linux-2619-rc1g2.orig/arch/powerpc/platforms/iseries/Kconfig
> > +++ linux-2619-rc1g2/arch/powerpc/platforms/iseries/Kconfig
> > @@ -3,7 +3,7 @@ menu "iSeries device drivers"
> > depends on PPC_ISERIES
> >
> > config VIOCONS
> > - tristate "iSeries Virtual Console Support (Obsolete)"
> > + tristate "iSeries Virtual Console Support (Obsolete)" if !VT
> > help
> >...
> > config VT
> > bool "Virtual terminal" if EMBEDDED
>
> With this dependency on EMBEDDED, you could as well simply remove
> VIOCONS...
>
> > select INPUT
> > - default y if !VIOCONS
>
> Removing the "default y" is wrong.
Oops, yes, agreed.
I don't see a way (using: make ARCH=powerpc iseries_defconfig,
which wants to enable VIOCONS) to prevent VT from being enabled
so that VIOCONS can be enabled.
However, since VIOCONS is marked (Obsolete) and since the powerpc
people don't comment on this patch & problem, maybe Judith is the
only person who cares.
> > ---help---
> > If you say Y here, you will get support for terminal devices with
> > display and keyboard devices. These are called "virtual" because you
> >...
---
~Randy
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Add Kconfig dependency !VT for VIOCONS
2006-10-10 16:10 ` Randy Dunlap
@ 2006-10-11 3:56 ` Adrian Bunk
2006-10-11 4:08 ` Randy Dunlap
0 siblings, 1 reply; 9+ messages in thread
From: Adrian Bunk @ 2006-10-11 3:56 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linuxppc-dev, linux-kernel
On Tue, Oct 10, 2006 at 09:10:04AM -0700, Randy Dunlap wrote:
> On Tue, 10 Oct 2006 06:55:34 +0200 Adrian Bunk wrote:
>
> > On Fri, Oct 06, 2006 at 02:34:37PM -0700, Randy Dunlap wrote:
> > > On Fri, 6 Oct 2006 13:00:07 -0700 Judith Lebzelter wrote:
> > >
> > > > Actually, this gets rid of the CONFIG_VIOCONS from my .config, but
> > > > then I get another warning when I build:
> > > >
> > > > Warning! Found recursive dependency: VT VIOCONS VT
> > > >
> > > > Can anyone suggest something?
> > >
> > > I think that your patch is mostly good/correct, but one more line
> > > is needed on the VT side: a deletion.
> > >
> > > This works for me:
> > >
> > > From: Randy Dunlap <rdunlap@xenotime.net>
> > >
> > > Make allmodconfig .config build successfully by making VIOCONS
> > > available only if VT=n. VT need not check VIOCONS.
> > >
> > > Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> > > ---
> > > arch/powerpc/platforms/iseries/Kconfig | 2 +-
> > > drivers/char/Kconfig | 1 -
> > > 2 files changed, 1 insertion(+), 2 deletions(-)
> > >
> > > --- linux-2619-rc1g2.orig/arch/powerpc/platforms/iseries/Kconfig
> > > +++ linux-2619-rc1g2/arch/powerpc/platforms/iseries/Kconfig
> > > @@ -3,7 +3,7 @@ menu "iSeries device drivers"
> > > depends on PPC_ISERIES
> > >
> > > config VIOCONS
> > > - tristate "iSeries Virtual Console Support (Obsolete)"
> > > + tristate "iSeries Virtual Console Support (Obsolete)" if !VT
> > > help
> > >...
> > > config VT
> > > bool "Virtual terminal" if EMBEDDED
> >
> > With this dependency on EMBEDDED, you could as well simply remove
> > VIOCONS...
> >
> > > select INPUT
> > > - default y if !VIOCONS
> >
> > Removing the "default y" is wrong.
>
> Oops, yes, agreed.
>
> I don't see a way (using: make ARCH=powerpc iseries_defconfig,
> which wants to enable VIOCONS) to prevent VT from being enabled
> so that VIOCONS can be enabled.
With iseries_defconfig, CONFIG_VT is not enabled.
> However, since VIOCONS is marked (Obsolete) and since the powerpc
> people don't comment on this patch & problem, maybe Judith is the
> only person who cares.
allmodconfig turns on CONFIG_EMBEDDED.
> ~Randy
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Add Kconfig dependency !VT for VIOCONS
2006-10-11 3:56 ` Adrian Bunk
@ 2006-10-11 4:08 ` Randy Dunlap
2006-10-11 4:30 ` Adrian Bunk
0 siblings, 1 reply; 9+ messages in thread
From: Randy Dunlap @ 2006-10-11 4:08 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linuxppc-dev, linux-kernel
On Wed, 11 Oct 2006 05:56:29 +0200 Adrian Bunk wrote:
> On Tue, Oct 10, 2006 at 09:10:04AM -0700, Randy Dunlap wrote:
> > On Tue, 10 Oct 2006 06:55:34 +0200 Adrian Bunk wrote:
> >
> > > On Fri, Oct 06, 2006 at 02:34:37PM -0700, Randy Dunlap wrote:
> > > > On Fri, 6 Oct 2006 13:00:07 -0700 Judith Lebzelter wrote:
> > > >
> > > > > Actually, this gets rid of the CONFIG_VIOCONS from my .config, but
> > > > > then I get another warning when I build:
> > > > >
> > > > > Warning! Found recursive dependency: VT VIOCONS VT
> > > > >
> > > > > Can anyone suggest something?
> > > >
> > > > I think that your patch is mostly good/correct, but one more line
> > > > is needed on the VT side: a deletion.
> > > >
> > > > This works for me:
> > > >
> > > > From: Randy Dunlap <rdunlap@xenotime.net>
> > > >
> > > > Make allmodconfig .config build successfully by making VIOCONS
> > > > available only if VT=n. VT need not check VIOCONS.
> > > >
> > > > Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> > > > ---
> > > > arch/powerpc/platforms/iseries/Kconfig | 2 +-
> > > > drivers/char/Kconfig | 1 -
> > > > 2 files changed, 1 insertion(+), 2 deletions(-)
> > > >
> > > > --- linux-2619-rc1g2.orig/arch/powerpc/platforms/iseries/Kconfig
> > > > +++ linux-2619-rc1g2/arch/powerpc/platforms/iseries/Kconfig
> > > > @@ -3,7 +3,7 @@ menu "iSeries device drivers"
> > > > depends on PPC_ISERIES
> > > >
> > > > config VIOCONS
> > > > - tristate "iSeries Virtual Console Support (Obsolete)"
> > > > + tristate "iSeries Virtual Console Support (Obsolete)" if !VT
> > > > help
> > > >...
> > > > config VT
> > > > bool "Virtual terminal" if EMBEDDED
> > >
> > > With this dependency on EMBEDDED, you could as well simply remove
> > > VIOCONS...
> > >
> > > > select INPUT
> > > > - default y if !VIOCONS
> > >
> > > Removing the "default y" is wrong.
> >
> > Oops, yes, agreed.
> >
> > I don't see a way (using: make ARCH=powerpc iseries_defconfig,
> > which wants to enable VIOCONS) to prevent VT from being enabled
> > so that VIOCONS can be enabled.
>
> With iseries_defconfig, CONFIG_VT is not enabled.
>
> > However, since VIOCONS is marked (Obsolete) and since the powerpc
> > people don't comment on this patch & problem, maybe Judith is the
> > only person who cares.
>
> allmodconfig turns on CONFIG_EMBEDDED.
So am I doing this incorrectly?
$ make ARCH=powerpc iseries_defconfig
$editor .config
CONFIG_VT=y
...
#
# iSeries device drivers
#
CONFIG_VIODASD=y
CONFIG_VIOCD=m
CONFIG_VIOTAPE=m
CONFIG_VIOPATH=y
---
~Randy
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Add Kconfig dependency !VT for VIOCONS
2006-10-11 4:08 ` Randy Dunlap
@ 2006-10-11 4:30 ` Adrian Bunk
2006-10-11 4:35 ` Randy Dunlap
0 siblings, 1 reply; 9+ messages in thread
From: Adrian Bunk @ 2006-10-11 4:30 UTC (permalink / raw)
To: Randy Dunlap; +Cc: linuxppc-dev, linux-kernel
On Tue, Oct 10, 2006 at 09:08:58PM -0700, Randy Dunlap wrote:
> On Wed, 11 Oct 2006 05:56:29 +0200 Adrian Bunk wrote:
>
> > On Tue, Oct 10, 2006 at 09:10:04AM -0700, Randy Dunlap wrote:
> > > On Tue, 10 Oct 2006 06:55:34 +0200 Adrian Bunk wrote:
> > >
> > > > On Fri, Oct 06, 2006 at 02:34:37PM -0700, Randy Dunlap wrote:
> > > > > On Fri, 6 Oct 2006 13:00:07 -0700 Judith Lebzelter wrote:
> > > > >
> > > > > > Actually, this gets rid of the CONFIG_VIOCONS from my .config, but
> > > > > > then I get another warning when I build:
> > > > > >
> > > > > > Warning! Found recursive dependency: VT VIOCONS VT
> > > > > >
> > > > > > Can anyone suggest something?
> > > > >
> > > > > I think that your patch is mostly good/correct, but one more line
> > > > > is needed on the VT side: a deletion.
> > > > >
> > > > > This works for me:
> > > > >
> > > > > From: Randy Dunlap <rdunlap@xenotime.net>
> > > > >
> > > > > Make allmodconfig .config build successfully by making VIOCONS
> > > > > available only if VT=n. VT need not check VIOCONS.
> > > > >
> > > > > Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> > > > > ---
> > > > > arch/powerpc/platforms/iseries/Kconfig | 2 +-
> > > > > drivers/char/Kconfig | 1 -
> > > > > 2 files changed, 1 insertion(+), 2 deletions(-)
> > > > >
> > > > > --- linux-2619-rc1g2.orig/arch/powerpc/platforms/iseries/Kconfig
> > > > > +++ linux-2619-rc1g2/arch/powerpc/platforms/iseries/Kconfig
> > > > > @@ -3,7 +3,7 @@ menu "iSeries device drivers"
> > > > > depends on PPC_ISERIES
> > > > >
> > > > > config VIOCONS
> > > > > - tristate "iSeries Virtual Console Support (Obsolete)"
> > > > > + tristate "iSeries Virtual Console Support (Obsolete)" if !VT
> > > > > help
> > > > >...
> > > > > config VT
> > > > > bool "Virtual terminal" if EMBEDDED
> > > >
> > > > With this dependency on EMBEDDED, you could as well simply remove
> > > > VIOCONS...
> > > >
> > > > > select INPUT
> > > > > - default y if !VIOCONS
> > > >
> > > > Removing the "default y" is wrong.
> > >
> > > Oops, yes, agreed.
> > >
> > > I don't see a way (using: make ARCH=powerpc iseries_defconfig,
> > > which wants to enable VIOCONS) to prevent VT from being enabled
> > > so that VIOCONS can be enabled.
> >
> > With iseries_defconfig, CONFIG_VT is not enabled.
> >
> > > However, since VIOCONS is marked (Obsolete) and since the powerpc
> > > people don't comment on this patch & problem, maybe Judith is the
> > > only person who cares.
> >
> > allmodconfig turns on CONFIG_EMBEDDED.
>
> So am I doing this incorrectly?
>
> $ make ARCH=powerpc iseries_defconfig
>
> $editor .config
>
> CONFIG_VT=y
> ...
> #
> # iSeries device drivers
> #
> CONFIG_VIODASD=y
> CONFIG_VIOCD=m
> CONFIG_VIOTAPE=m
> CONFIG_VIOPATH=y
CONFIG_VIOCONS is not enabled.
> ~Randy
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] Add Kconfig dependency !VT for VIOCONS
2006-10-11 4:30 ` Adrian Bunk
@ 2006-10-11 4:35 ` Randy Dunlap
0 siblings, 0 replies; 9+ messages in thread
From: Randy Dunlap @ 2006-10-11 4:35 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linuxppc-dev, linux-kernel
On Wed, 11 Oct 2006 06:30:06 +0200 Adrian Bunk wrote:
> On Tue, Oct 10, 2006 at 09:08:58PM -0700, Randy Dunlap wrote:
> > On Wed, 11 Oct 2006 05:56:29 +0200 Adrian Bunk wrote:
> >
> > > On Tue, Oct 10, 2006 at 09:10:04AM -0700, Randy Dunlap wrote:
> > > > On Tue, 10 Oct 2006 06:55:34 +0200 Adrian Bunk wrote:
> > > >
> > > > > On Fri, Oct 06, 2006 at 02:34:37PM -0700, Randy Dunlap wrote:
> > > > > > On Fri, 6 Oct 2006 13:00:07 -0700 Judith Lebzelter wrote:
> > > > > >
> > > > > > > Actually, this gets rid of the CONFIG_VIOCONS from my .config, but
> > > > > > > then I get another warning when I build:
> > > > > > >
> > > > > > > Warning! Found recursive dependency: VT VIOCONS VT
> > > > > > >
> > > > > > > Can anyone suggest something?
> > > > > >
> > > > > > I think that your patch is mostly good/correct, but one more line
> > > > > > is needed on the VT side: a deletion.
> > > > > >
> > > > > > This works for me:
> > > > > >
> > > > > > From: Randy Dunlap <rdunlap@xenotime.net>
> > > > > >
> > > > > > Make allmodconfig .config build successfully by making VIOCONS
> > > > > > available only if VT=n. VT need not check VIOCONS.
> > > > > >
> > > > > > Signed-off-by: Randy Dunlap <rdunlap@xenotime.net>
> > > > > > ---
> > > > > > arch/powerpc/platforms/iseries/Kconfig | 2 +-
> > > > > > drivers/char/Kconfig | 1 -
> > > > > > 2 files changed, 1 insertion(+), 2 deletions(-)
> > > > > >
> > > > > > --- linux-2619-rc1g2.orig/arch/powerpc/platforms/iseries/Kconfig
> > > > > > +++ linux-2619-rc1g2/arch/powerpc/platforms/iseries/Kconfig
> > > > > > @@ -3,7 +3,7 @@ menu "iSeries device drivers"
> > > > > > depends on PPC_ISERIES
> > > > > >
> > > > > > config VIOCONS
> > > > > > - tristate "iSeries Virtual Console Support (Obsolete)"
> > > > > > + tristate "iSeries Virtual Console Support (Obsolete)" if !VT
> > > > > > help
> > > > > >...
> > > > > > config VT
> > > > > > bool "Virtual terminal" if EMBEDDED
> > > > >
> > > > > With this dependency on EMBEDDED, you could as well simply remove
> > > > > VIOCONS...
> > > > >
> > > > > > select INPUT
> > > > > > - default y if !VIOCONS
> > > > >
> > > > > Removing the "default y" is wrong.
> > > >
> > > > Oops, yes, agreed.
> > > >
> > > > I don't see a way (using: make ARCH=powerpc iseries_defconfig,
> > > > which wants to enable VIOCONS) to prevent VT from being enabled
> > > > so that VIOCONS can be enabled.
> > >
> > > With iseries_defconfig, CONFIG_VT is not enabled.
> > >
> > > > However, since VIOCONS is marked (Obsolete) and since the powerpc
> > > > people don't comment on this patch & problem, maybe Judith is the
> > > > only person who cares.
> > >
> > > allmodconfig turns on CONFIG_EMBEDDED.
> >
> > So am I doing this incorrectly?
> >
> > $ make ARCH=powerpc iseries_defconfig
> >
> > $editor .config
> >
> > CONFIG_VT=y
> > ...
> > #
> > # iSeries device drivers
> > #
> > CONFIG_VIODASD=y
> > CONFIG_VIOCD=m
> > CONFIG_VIOTAPE=m
> > CONFIG_VIOPATH=y
>
> CONFIG_VIOCONS is not enabled.
Yep. That was with my patch.
But I see what you mean. Thanks.
---
~Randy
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2006-10-11 4:33 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-10-06 18:05 [PATCH] Add Kconfig dependency !VT for VIOCONS Judith Lebzelter
2006-10-06 20:00 ` Judith Lebzelter
2006-10-06 21:34 ` Randy Dunlap
2006-10-10 4:55 ` Adrian Bunk
2006-10-10 16:10 ` Randy Dunlap
2006-10-11 3:56 ` Adrian Bunk
2006-10-11 4:08 ` Randy Dunlap
2006-10-11 4:30 ` Adrian Bunk
2006-10-11 4:35 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).